Fix namespace in blockless namespace with same name

[timotheeguerin]

fix #4049

[azure-sdk]

All changed packages have been documented.

• ✅ @typespec/compiler

Show changes

@typespec/compiler - fix ✏️

Allow using compact namespace form Foo.Bar when inside another namespace,> tsp,> namespace MyOrg.MyProject {,> namespace MyModule.MySubmodule { // <-- this used to emit an error,> // ...,> },> },>

@typespec/compiler - breaking ✏️

Fix issue where naming a namespace with the same name as the blockless namespace would merge with it instead of creating a subnamespace like any other name would.,> ,> tsp,> namespace MyOrg.MyProject;,> ,> namespace MyOrg.MyProject.MyArea {,> model A {},> },> ,> namespace MyArea2 {,> model B {},> },> ,> ,> Previously model A would end-up in namespace MyOrg.MyProject.MyArea and model B in MyOrg.MyProject.MyArea2. With this change model A will now be in MyOrg.MyProject.MyOrg.MyProject.MyArea. To achieve the previous behavior the above code should be written as:,> ,> tsp,> namespace MyOrg.MyProject;,> ,> namespace MyArea {,> model A {},> },> ,> namespace MyArea2 {,> model B {},> },>

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website	📚 Next docs

[chrisradek]

Implementation looks good. I didn't fully understand the issue until reading the changelog because looking at the playground example my brain wanted to think those namespaces should merge, but I understand why they shouldn't.

Obviously needs breaking change review.