Fix Bug for OpenAPI 3 Emitter crash on @useAuth({}) #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skywing918
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
emitter:openapi3
wanlwanl
reviewed
Aug 9, 2024
markcowl
requested changes
Aug 12, 2024
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Closed
4 tasks
chrisradek
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Changes look good to me - also tested and confirmed they fix #4272 as well (empty model vs empty model expression)
markcowl
approved these changes
Aug 27, 2024
weidongxu-microsoft
pushed a commit
to weidongxu-microsoft/typespec
that referenced
this pull request
Sep 3, 2024
OpenAPI 3 Emitter crash on @useAuth({}).
seems the diagnostics is not initial before add item.
fix: microsoft#4097
---------
Co-authored-by: Kyle Zhang <v-zhanh@microsoft.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Co-authored-by: Christopher Radek <14189820+chrisradek@users.noreply.github.com>
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
OpenAPI 3 Emitter crash on @useAuth({}).
seems the diagnostics is not initial before add item.
fix: microsoft#4097
---------
Co-authored-by: Kyle Zhang <v-zhanh@microsoft.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Co-authored-by: Christopher Radek <14189820+chrisradek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI 3 Emitter crash on @useAuth({}).
seems the diagnostics is not initial before add item.
fix: #4097