Make diagnostic code link to linter rule doc in IDE #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
chrisradek
approved these changes
Aug 12, 2024
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
Saw that eslint extension was doing this. Part solution to microsoft#3043 which could also provide an explicit `Open documentation Url` command <img width="568" alt="image" src="https://github.com/user-attachments/assets/c3a322d2-17c7-45d9-962c-028c1e9cc93c"> For now all the API that gives that is limited to linter as other diagnostic cannot define a url. Due to this limited usage I left the API internal. The goal would be that any diagnostic can define a documentation url and connect to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw that eslint extension was doing this. Part solution to #3043 which could also provide an explicit
Open documentation UrlcommandFor now all the API that gives that is limited to linter as other diagnostic cannot define a url. Due to this limited usage I left the API internal. The goal would be that any diagnostic can define a documentation url and connect to this.