tsp-openapi3 improve conversion of OpenAPI3 component schemas into TypeSpec data types #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisradek
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
packages/openapi3/src/cli/actions/convert/generators/generate-types.ts
Outdated
Show resolved
Hide resolved
timotheeguerin
approved these changes
Aug 12, 2024
added 3 commits
August 12, 2024 14:36
chrisradek
added
the
openapi3:converter
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
…peSpec data types (microsoft#4149) Fixes microsoft#4080 and microsoft#4088 This also fixes a few bugs/rough edges around generating TypeSpec types from OpenAPI3 component schemas. Still 2 things to follow up with that I'll create issues for: 1. Support `allOf` with more than 1 member. Likely this will result in spreading all the members, except extending 1 if there is 1 that has a discriminator. (microsoft#4152) 2. Place all component schemas under a `Schemas` namespace (and do something similar for `Parameters`) to prevent name collisions. (microsoft#4151) --------- Co-authored-by: Christopher Radek <Christopher.Radek@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4080 and #4088
This also fixes a few bugs/rough edges around generating TypeSpec types from OpenAPI3 component schemas.
Still 2 things to follow up with that I'll create issues for:
allOfwith more than 1 member. Likely this will result in spreading all the members, except extending 1 if there is 1 that has a discriminator. (tsp-openapi3 - allOf with more than one member not supported #4152)Schemasnamespace (and do something similar forParameters) to prevent name collisions. (tsp-openapi3 - prevent collisions when same name is used in Open API 3 components categories. #4151)