Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gtkmm] Update to 4.0.0 #16815

Closed
wants to merge 6 commits into from
Closed

[gtkmm] Update to 4.0.0 #16815

wants to merge 6 commits into from

Conversation

electron271
Copy link

Updating gtkmm to 4.0.0

Describe the pull request

Updates gtkmm to 4.0.0

@ghost
Copy link

ghost commented Mar 21, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 16815 in repo microsoft/vcpkg

@electron271
Copy link
Author

tried running, and so far its working well installing gtkmm 4

@electron271
Copy link
Author

nope didnt work

Error: Building package pcre:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: pcre:x86-windows
  Vcpkg version: 2021-01-13-d67989bce1043b98092ac45996a8230a059a2d7e

@JackBoosY JackBoosY changed the title Update portfile.cmake [gtkmm] Update to 4.0.0 Mar 22, 2021
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Mar 22, 2021
NancyLi1013
NancyLi1013 suggested changes Mar 22, 2021
View reviewed changes
ports/gtkmm/CONTROL Outdated Show resolved Hide resolved
ports/gtkmm/portfile.cmake Show resolved Hide resolved
ports/gtkmm/portfile.cmake Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

Hi @electron271

Thanks for this PR.

It seems that you didn't update the patch.

-- Applying patch fix_properties.patch
CMake Error at scripts/cmake/z_vcpkg_apply_patches.cmake:57 (message):
  Applying patch failed: Checking patch MSVC_Net2013/gdkmm.vcxproj...

  error: MSVC_Net2013/gdkmm.vcxproj: No such file or directory

  Checking patch MSVC_Net2013/gdkmm.vcxproj.filters...

  error: MSVC_Net2013/gdkmm.vcxproj.filters: No such file or directory

  Checking patch MSVC_Net2013/gtkmm-build-defines.props...

  error: MSVC_Net2013/gtkmm-build-defines.props: No such file or directory

  Checking patch MSVC_Net2013/gtkmm-version-paths.props...

  error: MSVC_Net2013/gtkmm-version-paths.props: No such file or directory

  Checking patch MSVC_Net2013/gtkmm.vcxproj...

  error: MSVC_Net2013/gtkmm.vcxproj: No such file or directory

  Checking patch MSVC_Net2013/gtkmm.vcxproj.filters...

  error: MSVC_Net2013/gtkmm.vcxproj.filters: No such file or directory

@electron271
Copy link
Author

Got all of this, going to change. This is my first pull request and couldn't find much docs of how to update a lib.

electron271 and others added 3 commits March 22, 2021 09:44
@electron271 @NancyLi1013
Update ports/gtkmm/CONTROL
ae2dcff 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@electron271
Update portfile.cmake
d5a12e7
@electron271
Update portfile.cmake
419cf5a
@electron271
Copy link
Author

@NancyLi1013 How do I update the patch?

@NancyLi1013
Copy link
Contributor

@electron271

Please refer to this doc https://github.com/microsoft/vcpkg/blob/master/docs/examples/patching.md

@electron271
Copy link
Author

Ok, attempting patch right now.

@electron271
Copy link
Author

Still having issues figuring out how to add the patch

@eszlari
Copy link

eszlari commented Mar 25, 2021

Shouldn't this be a new port (gtkmm4)?

@electron271
Copy link
Author

🤔maybe?

@Neumann-A Neumann-A mentioned this pull request Mar 30, 2021
Merged
3 tasks
@electron271
Copy link
Author

This pr is a little outdated, so I'm closing it.

@electron271 electron271 closed this Apr 9, 2021
@electron271 electron271 deleted the patch-1 branch April 9, 2021 13:42
@electron271 electron271 restored the patch-1 branch April 9, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 requested changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GTKmm update to 4.0
4 participants
@electron271 @NancyLi1013 @eszlari @JackBoosY