Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cairo] Windows: Fix cairo dll definition #17596

Merged
merged 5 commits into from
May 3, 2021
Merged

[cairo] Windows: Fix cairo dll definition #17596

merged 5 commits into from
May 3, 2021

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Apr 30, 2021 •
edited
Loading

closes #17595 (confirmed to work #17595 (comment))

(similar fix as #14946 for fontconfig)

@Neumann-A Neumann-A mentioned this pull request Apr 30, 2021
Closed
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label May 2, 2021
@JackBoosY
Copy link
Contributor

Waiting for #17586.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label May 2, 2021
@Neumann-A
Copy link
Contributor Author

@JackBoosY: Wrong PR? you probably ment #17610

@JackBoosY
Copy link
Contributor

@Neumann-A Yeah...

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label May 3, 2021
@ras0219-msft ras0219-msft merged commit 95836f4 into microsoft:master May 3, 2021
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the continued fixes :)

@Neumann-A Neumann-A deleted the fix_cairo_dll_def branch September 18, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cairo] CMake does not copy necessary dlls after glib/gtk port update.
4 participants
@Neumann-A @JackBoosY @ras0219-msft @NancyLi1013