Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openmvg] no absolute paths #22342

Merged
merged 1 commit into from
Mar 2, 2022
Merged

[openmvg] no absolute paths #22342

merged 1 commit into from
Mar 2, 2022

Conversation

autoantwort
Copy link
Contributor

For #20469

@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 5, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 5, 2022
@strega-nil-ms strega-nil-ms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jan 6, 2022
strega-nil-ms
strega-nil-ms suggested changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing -targets.cmake looks really wrong...

ports/openmvg/portfile.cmake Show resolved Hide resolved
@strega-nil-ms strega-nil-ms added requires:author-response and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Jan 7, 2022
@strega-nil-ms
Copy link
Contributor

poke @autoantwort for response

@strega-nil-ms strega-nil-ms removed the info:reviewed Pull Request changes follow basic guidelines label Jan 7, 2022
@LilyWangLL
Copy link
Contributor

@autoantwort Could you please resolve the conflicts?

github-actions[bot]
github-actions bot approved these changes Feb 14, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/openmvg/vcpkg.json

Valid values for the license field can be found in the documentation

@autoantwort autoantwort force-pushed the openmvg-no-absolute branch 2 times, most recently from 3306ea1 to 77a4479 Compare February 21, 2022 20:22
github-actions[bot]
github-actions bot approved these changes Feb 21, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/openmvg/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:author-response labels Feb 22, 2022
@vicroms vicroms merged commit ffb2887 into microsoft:master Mar 2, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 2, 2022
@ekilmer
Merge branch 'master' into more-lief
205e031 
* master: (108 commits)
  [calceph] update to version 3.5.1 (microsoft#23325)
  [SpeexDSP] Missing windows definitions (microsoft#23296)
  [triton] Fix usage (microsoft#23250)
  [vcpkg_configure_make] Report warning when unresolved arguments are passed in (microsoft#22567)
  [openmvg] no absolute paths (microsoft#22342)
  [python2] no absolute paths (microsoft#22329)
  [libcpplocate] New port (microsoft#23173)
  [Intelrdfpmathlib] Fix post build error (microsoft#23286)
  [docs] Update maintainer guide to include CMAKE_REQUIRE_FIND_PACKAGE. (microsoft#23321)
  [new-port-template] Remove deprecated cmake (microsoft#23283)
  [xtensor] Update to 0.24.0 (microsoft#23238)
  [pcl/soil2] Disable optimizations for individual function (microsoft#23252)
  [cnats] Add new port (C client for the NATS messaging system). (microsoft#23258)
  [nanobench] Update to 4.3.6 (microsoft#23262)
  [elfio] Update elfio to 3.10 (microsoft#23263)
  [tomlplusplus] Update to 3.0.1 (microsoft#23268)
  [shaderc] Fix CMake export target files (microsoft#23269)
  [PCL] Fix namespace and  VS2022 error C3052 (microsoft#23273)
  [libressl] update to 3.4.2 (microsoft#23276)
  [asio-grpc] Update to 1.4.0 (microsoft#23277)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

@github-actions GitHub Actions github-actions approved these changes

@strega-nil-ms strega-nil-ms Awaiting requested review from strega-nil-ms

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autoantwort @strega-nil-ms @LilyWangLL @vicroms