Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-tools] update cmake and git (windows only) #22985

Merged
merged 29 commits into from
Feb 26, 2022
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6940916
update cmake to 3.22.0-rc3 to verify catalogue compatibility and be r…
cenit Nov 16, 2021
519edab
update to cmake 3.22 final release
cenit Nov 19, 2021
0df6505
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal Nov 24, 2021
9385e92
Merge branch 'master' into dev/cenit/cmake322
cenit Nov 29, 2021
2674173
Merge branch 'master' into dev/cenit/cmake322
cenit Dec 9, 2021
0e6529b
[vcpkgTools] update to cmake 3.22.1
cenit Dec 9, 2021
b1e8f5e
Merge branch 'microsoft:master' into dev/cenit/cmake322
cenit Dec 11, 2021
ee14b84
Merge branch 'master' into dev/cenit/cmake322
cenit Dec 17, 2021
f006d50
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
Dec 29, 2021
cdad3c5
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal Jan 12, 2022
969ba7e
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal Feb 4, 2022
bc1ce81
Merge remote-tracking branch 'cenit/dev/cenit/cmake322' into cmake_up…
Neumann-A Feb 7, 2022
ac921e5
update test port
Neumann-A Feb 7, 2022
f49011a
update cmake to 3.22.2
Neumann-A Feb 7, 2022
a042f4e
fix missing uuid on osx in ignition-transport.
Neumann-A Feb 7, 2022
428f78c
modernize
Neumann-A Feb 7, 2022
ea1996a
fix hash
Neumann-A Feb 7, 2022
0c7e5f7
fix qtbase regression
Neumann-A Feb 7, 2022
5c00b62
try fixing the pc file search
Neumann-A Feb 8, 2022
5ba5710
hidaoi give trace logs
Neumann-A Feb 8, 2022
04c06a2
give me trace output
Neumann-A Feb 8, 2022
37db851
bit of pkgconf changes. Need system search paths for pkgconf to work …
Neumann-A Feb 8, 2022
608af50
fix underscore
Neumann-A Feb 8, 2022
f26c927
remove extra x
Neumann-A Feb 8, 2022
b411bcc
Merge remote-tracking branch 'upstream/master' into cmake_update_3.22.2
Neumann-A Feb 24, 2022
b106059
revert port changes
Neumann-A Feb 24, 2022
25030ab
add license to cmake test port
Neumann-A Feb 24, 2022
4d6220f
fix arm regression due to not finding taglib.
Feb 25, 2022
fdc0716
version stuff
Feb 25, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ports/hidapi/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ vcpkg_from_github(
vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS -DHIDAPI_BUILD_HIDTEST=OFF
--trace-expand
)
vcpkg_cmake_install()

Expand Down
4 changes: 2 additions & 2 deletions ports/ignition-transport4/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ignition-transport4",
"version-string": "4.0.0",
"port-version": 4,
"port-version": 5,
"description": "Transport middleware for robotics",
"dependencies": [
"cppzmq",
Expand All @@ -10,7 +10,7 @@
"ignition-msgs1",
{
"name": "libuuid",
"platform": "!windows & !uwp & !osx"
"platform": "!windows"
},
"protobuf",
"zeromq"
Expand Down
2 changes: 1 addition & 1 deletion ports/ignition-transport9/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"ignition-msgs6",
{
"name": "libuuid",
"platform": "!windows & !uwp & !osx"
"platform": "!windows"
},
"protobuf",
"sqlite3",
Expand Down
21 changes: 13 additions & 8 deletions ports/qtbase/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ set(${PORT}_PATCHES
fix_cmake_build.patch
harfbuzz.patch
fix_egl.patch
xkb-common.patch
)

if(NOT VCPKG_USE_HEAD_VERSION AND NOT QT_IS_LATEST)
Expand All @@ -39,8 +40,7 @@ set(INPUT_OPTIONS)
foreach(_input IN LISTS input_vars)
if(_input MATCHES "(png|jpeg)" )
list(APPEND INPUT_OPTIONS -DINPUT_lib${_input}:STRING=)
elseif(_input MATCHES "(sql-sqlite)")
list(APPEND INPUT_OPTIONS -DINPUT_sqlite:STRING=) # Not yet used be the cmake build
elseif(_input MATCHES "(sql-sqlite)") # Not yet used by the cmake build
else()
list(APPEND INPUT_OPTIONS -DINPUT_${_input}:STRING=)
endif()
Expand All @@ -58,7 +58,7 @@ endforeach()
# General features:
vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
"appstore-compliant" FEATURE_appstore-compliant
"appstore-compliant" FEATURE_appstore_compliant
"zstd" FEATURE_zstd
"framework" FEATURE_framework
"concurrent" FEATURE_concurrent
Expand All @@ -79,8 +79,8 @@ INVERTED_FEATURES
list(APPEND FEATURE_OPTIONS -DCMAKE_DISABLE_FIND_PACKAGE_Libudev:BOOL=ON)
list(APPEND FEATURE_OPTIONS -DFEATURE_xml:BOOL=ON)

if(QT_NAMESPACE)
list(APPEND FEATURE_OPTIONS -DQT_NAMESPACE:STRING=${QT_NAMESPACE})
if(VCPKG_QT_NAMESPACE)
list(APPEND FEATURE_OPTIONS "-DQT_NAMESPACE:STRING=${VCPKG_QT_NAMESPACE}")
endif()

# Corelib features:
Expand Down Expand Up @@ -130,6 +130,12 @@ vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_GUI_OPTIONS
"jpeg" FEATURE_jpeg
"png" FEATURE_png
#"opengl" INPUT_opengl=something
"xlib" FEATURE_xlib
"xkb" FEATURE_xkb
"xcb" FEATURE_xcb
"xcb-xlib" FEATURE_xcb_xlib
"xkbcommon-x11" FEATURE_xkbcommon_x11
"xrender" FEATURE_xrender
INVERTED_FEATURES
Neumann-A marked this conversation as resolved.
Show resolved Hide resolved
"vulkan" CMAKE_DISABLE_FIND_PACKAGE_Vulkan
"egl" CMAKE_DISABLE_FIND_PACKAGE_EGL
Expand Down Expand Up @@ -238,7 +244,6 @@ qt_install_submodule(PATCHES ${${PORT}_PATCHES}
-DFEATURE_relocatable:BOOL=ON
CONFIGURE_OPTIONS_RELEASE
CONFIGURE_OPTIONS_DEBUG
-DQT_NO_MAKE_TOOLS:BOOL=ON
-DFEATURE_debug:BOOL=ON
)

Expand Down Expand Up @@ -335,7 +340,7 @@ if(installed_to_host)
endif()
set(_file "${CMAKE_CURRENT_LIST_DIR}/qt.conf.in")
set(REL_PATH "")
set(REL_HOST_TO_DATA "\${CURRENT_INSTALLED_DIR}")
set(REL_HOST_TO_DATA "\${CURRENT_INSTALLED_DIR}/")
configure_file("${_file}" "${CURRENT_PACKAGES_DIR}/tools/Qt6/qt_release.conf" @ONLY) # For vcpkg-qmake
set(BACKUP_CURRENT_INSTALLED_DIR "${CURRENT_INSTALLED_DIR}")
set(BACKUP_CURRENT_HOST_INSTALLED_DIR "${CURRENT_HOST_INSTALLED_DIR}")
Expand All @@ -350,7 +355,7 @@ configure_file("${_file}" "${CURRENT_PACKAGES_DIR}/tools/Qt6/bin/qt.debug.conf")

set(CURRENT_INSTALLED_DIR "${BACKUP_CURRENT_INSTALLED_DIR}")
set(CURRENT_HOST_INSTALLED_DIR "${BACKUP_CURRENT_HOST_INSTALLED_DIR}")
set(REL_HOST_TO_DATA "\${CURRENT_INSTALLED_DIR}")
set(REL_HOST_TO_DATA "\${CURRENT_INSTALLED_DIR}/")
configure_file("${_file}" "${CURRENT_PACKAGES_DIR}/tools/Qt6/qt_debug.conf" @ONLY) # For vcpkg-qmake

if(VCPKG_TARGET_IS_WINDOWS)
Expand Down
1 change: 1 addition & 0 deletions ports/qtbase/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@
"name": "qtbase",
"default-features": false,
"features": [
"concurrent",
"xkbcommon-x11",
"xlib"
]
Expand Down
19 changes: 19 additions & 0 deletions ports/qtbase/xkb-common.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
diff --git a/cmake/FindXKB_COMMON_X11.cmake b/cmake/FindXKB_COMMON_X11.cmake
index 6e849ba94..897b77aba 100644
--- a/cmake/FindXKB_COMMON_X11.cmake
+++ b/cmake/FindXKB_COMMON_X11.cmake
@@ -1,7 +1,11 @@
find_package(PkgConfig QUIET)

-pkg_check_modules(XKB_COMMON_X11 "xkbcommon-x11>=0.4.1" IMPORTED_TARGET)
+if(NOT TARGET PkgConfig::XKB_COMMON_X11)
+ pkg_check_modules(XKB_COMMON_X11 IMPORTED_TARGET xkbcommon-x11)

-if (NOT TARGET PkgConfig::XKB_COMMON_X11)
- set(XKB_COMMON_X11_FOUND 0)
+ if (NOT TARGET PkgConfig::XKB_COMMON_X11)
+ set(XKB_COMMON_X11_FOUND 0)
+ endif()
+else()
+ set(XKB_COMMON_X11_FOUND 1)
endif()
31 changes: 15 additions & 16 deletions scripts/test_ports/cmake/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,22 @@ vcpkg_from_gitlab(
OUT_SOURCE_PATH SOURCE_PATH
REPO cmake/cmake
REF
b7b0fb430397bafae4a7bd80b41d474c91a3b7f3
8428e39ed9cddb3b7f1a6f7a58cb8617503183d2
SHA512
3b0de26910bceaf4bc6546255bada4c502cd0fd32f44bc28b067f347c09d028c175a3243551bbe4bb64bcf312df9ff827e8fdbcb0b34a12e1ce4a26ba0799ee2
4a40656efe5854bd6b893d0b2b86eed5df42992d080edb9c0cb2da2c55ad8dd489a85072b138947933d94ef5ba90c7a59f0a4460e3722d0f898ceefbbf74d226
HEAD_REF master
)
set(OPTIONS)
if(NOT VCPKG_TARGET_IS_WINDOWS AND NOT VCPKG_TARGET_IS_UWP)
list(APPEND OPTIONS -DBUILD_CursesDialog=ON)
list(APPEND OPTIONS "-DBUILD_CursesDialog=ON")
else()
list(APPEND OPTIONS -DBUILD_CursesDialog=OFF)
list(APPEND OPTIONS "-DBUILD_CursesDialog=OFF")
endif()

if(VCPKG_CROSSCOMPILING)
list(APPEND OPTIONS -DQt6CoreTools_DIR=${CURRENT_HOST_INSTALLED_DIR}/share/Qt6CoreTools)
list(APPEND OPTIONS -DQt6WidgetsTools_DIR=${CURRENT_HOST_INSTALLED_DIR}/share/Qt6WidgetsTools)
list(APPEND OPTIONS -DQt6GuiTools_DIR=${CURRENT_HOST_INSTALLED_DIR}/share/Qt6GuiTools)
list(APPEND OPTIONS "-DQt6CoreTools_DIR=${CURRENT_HOST_INSTALLED_DIR}/share/Qt6CoreTools")
list(APPEND OPTIONS "-DQt6WidgetsTools_DIR=${CURRENT_HOST_INSTALLED_DIR}/share/Qt6WidgetsTools")
list(APPEND OPTIONS "-DQt6GuiTools_DIR=${CURRENT_HOST_INSTALLED_DIR}/share/Qt6GuiTools")
if(VCPKG_TARGET_ARCHITECTURE STREQUAL arm64 AND VCPKG_TARGET_IS_WINDOWS) # Remove if PR #16111 is merged
list(APPEND OPTIONS -DCMAKE_CROSSCOMPILING=ON -DCMAKE_SYSTEM_PROCESSOR:STRING=ARM64 -DCMAKE_SYSTEM_NAME:STRING=Windows)
endif()
Expand All @@ -30,9 +30,8 @@ if(VCPKG_TARGET_IS_WINDOWS AND NOT VCPKG_TARGET_IS_MINGW)
set(VCPKG_C_FLAGS "/D_CRT_DECLARE_NONSTDC_NAMES ${VCPKG_C_FLAGS}")
endif()

vcpkg_configure_cmake(
SOURCE_PATH ${SOURCE_PATH}
PREFER_NINJA
vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
${OPTIONS}
-DBUILD_TESTING=OFF
Expand All @@ -51,7 +50,7 @@ vcpkg_configure_cmake(
-DCMake_QT_MAJOR_VERSION:STRING=6
)

vcpkg_install_cmake(ADD_BIN_TO_PATH)
vcpkg_cmake_install(ADD_BIN_TO_PATH)
vcpkg_copy_pdbs()

if(NOT VCPKG_TARGET_IS_OSX)
Expand All @@ -65,16 +64,16 @@ if(NOT VCPKG_TARGET_IS_OSX)
vcpkg_copy_tools(TOOL_NAMES ${_tools} AUTO_CLEAN)
else()
# On OSX everything is within a CMake.app folder
file(MAKE_DIRECTORY ${CURRENT_PACKAGES_DIR}/tools)
file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/tools")
file(RENAME "${CURRENT_PACKAGES_DIR}/CMake.app" "${CURRENT_PACKAGES_DIR}/tools/CMake.app")
if(EXISTS "${CURRENT_PACKAGES_DIR}/debug/CMake.app")
file(MAKE_DIRECTORY ${CURRENT_PACKAGES_DIR}/tools/debug)
file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/tools/debug")
file(RENAME "${CURRENT_PACKAGES_DIR}/debug/CMake.app" "${CURRENT_PACKAGES_DIR}/tools/debug/CMake.app")
endif()
endif()

file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin)
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug)
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug")

# Handle copyright
configure_file(${SOURCE_PATH}/Copyright.txt ${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright COPYONLY)
configure_file("${SOURCE_PATH}/Copyright.txt" "${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright" COPYONLY)
7 changes: 5 additions & 2 deletions scripts/test_ports/cmake/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "cmake",
"version-string": "3.20.0",
"port-version": 1,
"version-string": "3.22.2",
"description": "CMake is an open-source, cross-platform family of tools designed to build, test and package software.",
"homepage": "https://cmake.org/",
"dependencies": [
Expand All @@ -18,6 +17,10 @@
},
"nghttp2",
"qtbase",
{
"name": "vcpkg-cmake",
"host": true
},
"zlib",
"zstd"
]
Expand Down
38 changes: 19 additions & 19 deletions scripts/vcpkgTools.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,25 @@
<archiveName>python-3.10.1-embed-win32.zip</archiveName>
</tool>
<tool name="cmake" os="windows">
<version>3.21.1</version>
<exeRelativePath>cmake-3.21.1-windows-i386\bin\cmake.exe</exeRelativePath>
<url>https://github.com/Kitware/CMake/releases/download/v3.21.1/cmake-3.21.1-windows-i386.zip</url>
<sha512>3aa0e9c904bf8abfc9441c1f0fd571e613ade7bc12f36211cd9006b4a2226552815ec8b00c8ef43583769d9d90996e75d2e832b3718ac3b85d3f9fb4db1cd60a</sha512>
<archiveName>cmake-3.21.1-windows-i386.zip</archiveName>
<version>3.22.2</version>
<exeRelativePath>cmake-3.22.2-windows-i386\bin\cmake.exe</exeRelativePath>
<url>https://github.com/Kitware/CMake/releases/download/v3.22.2/cmake-3.22.2-windows-i386.zip</url>
<sha512>969d3d58d56d8fa3cc3acae2b949bf58abab945f70ae292ff20c9060d845dfc094c613c367a924abff47f307cc33af1467cdb9b75bb857868e38b2c7cdc72f79</sha512>
<archiveName>cmake-3.22.2-windows-i386.zip</archiveName>
</tool>
<tool name="cmake" os="osx">
<version>3.21.1</version>
<exeRelativePath>cmake-3.21.1-macos-universal/CMake.app/Contents/bin/cmake</exeRelativePath>
<url>https://github.com/Kitware/CMake/releases/download/v3.21.1/cmake-3.21.1-macos-universal.tar.gz</url>
<sha512>0e5d3781101d6f54d916066719a0ff27d052b40e999dfd8e1f53d8d22d99e45cad22fc28b5d2a9e810b0cc8237e640d7747aff2a2c0896571c8a69ecdd0a9e41</sha512>
<archiveName>cmake-3.21.1-macos-universal.tar.gz</archiveName>
<version>3.22.2</version>
<exeRelativePath>cmake-3.22.2-macos-universal/CMake.app/Contents/bin/cmake</exeRelativePath>
<url>https://github.com/Kitware/CMake/releases/download/v3.22.2/cmake-3.22.2-macos-universal.tar.gz</url>
<sha512>08104f608ecb9a5cfef38e79f0957d21e425616c0677781445492f82cbfec805113e3b5eb4bc737b707bb26a00678e7bd55e17555a5611c08b0b9b44ac5136ac</sha512>
<archiveName>cmake-3.22.2-macos-universal.tar.gz</archiveName>
</tool>
<tool name="cmake" os="linux">
<version>3.21.1</version>
<exeRelativePath>cmake-3.21.1-linux-x86_64/bin/cmake</exeRelativePath>
<url>https://github.com/Kitware/CMake/releases/download/v3.21.1/cmake-3.21.1-Linux-x86_64.tar.gz</url>
<sha512>deb24087315bcf01d2969846246564a352b6f77521df6b235f9ef525450db9c89b32dca4ad78f93a356dd5ab7b587374d49fc1a892354760715a5ef1f88e925f</sha512>
<archiveName>cmake-3.21.1-linux-x86_64.tar.gz</archiveName>
<version>3.22.2</version>
<exeRelativePath>cmake-3.22.2-linux-x86_64/bin/cmake</exeRelativePath>
<url>https://github.com/Kitware/CMake/releases/download/v3.22.2/cmake-3.22.2-linux-x86_64.tar.gz</url>
<sha512>579e08b086f6903ef063697fca1dc2692f68a7341dd35998990b772b4221cdb5b1deecfa73bad9d46817ef09e58882b2adff9d64f959c01002c11448a878746b</sha512>
<archiveName>cmake-3.22.2linux-x86_64.tar.gz</archiveName>
</tool>
<tool name="cmake" os="freebsd">
<version>3.20.4</version>
Expand All @@ -36,11 +36,11 @@
<archiveName>cmake-3.20.4.txz</archiveName>
</tool>
<tool name="git" os="windows">
<version>2.32.0.2</version>
<version>2.35.1.2</version>
<exeRelativePath>mingw32\bin\git.exe</exeRelativePath>
<url>https://github.com/git-for-windows/git/releases/download/v2.32.0.windows.2/PortableGit-2.32.0.2-32-bit.7z.exe</url>
<sha512>867d8534972cbaf7a4224e25a14d484f8d17ef186f8d79e9a758afb90cf69541375cb7615a39702311f4809cb8371ef85c2b1a15bfffe9e48f0e597ac011b348</sha512>
<archiveName>PortableGit-2.32.0.2-32-bit.7z.exe</archiveName>
<url>https://github.com/git-for-windows/git/releases/download/v2.35.1.windows.2/PortableGit-2.35.1.2-32-bit.7z.exe</url>
<sha512>f98df16641a615bbc36c5c319c78abb780d824ff35ed5f2a095e2d5fce2acacfc7f6532c96f1c81d3d3cd8a642858cbd9de0e0e5fcde9ca11e6ad9f6598bb82f</sha512>
<archiveName>PortableGit-2.35.1.2-32-bit.7z.exe</archiveName>
</tool>
<tool name="git" os="linux">
<version>2.7.4</version>
Expand Down