Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python3] Fix <version> of Python in vcpkgTools.xml #23751

Merged
merged 1 commit into from
Mar 25, 2022
Merged

[python3] Fix <version> of Python in vcpkgTools.xml #23751

merged 1 commit into from
Mar 25, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Mar 24, 2022 •
edited
Loading

Describe the pull request

@JonLiu1993 JonLiu1993 self-assigned this Mar 25, 2022
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Mar 25, 2022
@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines and removed category:port-bug The issue is with a library, which is something the port should already support labels Mar 25, 2022
@dan-shaw dan-shaw merged commit f1080d1 into microsoft:master Mar 25, 2022
@Thomas1664 Thomas1664 deleted the python-version branch March 25, 2022 20:44
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 26, 2022
@ekilmer
Merge branch 'master' into more-lief
558f302 
* master: (103 commits)
  [lmdb] don't use msvc parameters with non-msvc compiler (microsoft#23653)
  Fix <version> of Python in vcpkgTools.xml (microsoft#23751)
  [sciter] escape quotes (microsoft#23752)
  [fuzzylite] Fix Linux build (microsoft#23658)
  [cpp-redis] Fix ‘sleep_for’ is not a member of ‘std::this_thread’ (microsoft#23762)
  [nlohmann-json] Fix usage text (microsoft#23749)
  [fontconfig] Do not create symlinks (microsoft#23735) (microsoft#23736)
  [winsparkle] Fix header file and debug path (microsoft#23739)
  [arb] Support dynamic build (microsoft#23743)
  [aws-sdk-cpp] update to 1.9.220 (microsoft#23729)
  Fix the VS2022 'unstable' queues. (microsoft#23742)
  [xmlsec] Bump to 1.2.33 (microsoft#23733)
  [unicorn] update to latest version v1.0.3 (microsoft#23745)
  [libpq] Update version to 14.1 2 (microsoft#22516)
  [libnoise] Export CMake files (microsoft#23682)
  [vcpk-ci] Trigger some test ports from vcpkg.cmake changes (microsoft#23430)
  [nlohmann-json] Add option to control implicit conversions behaviour (microsoft#22409)
  [libjuice] Update to 0.9.8 (microsoft#23153)
  [libgeotiff] Update to 1.7.1 (microsoft#23446)
  [minizip-ng] Updated minizip version and fixed windows build for previous version (microsoft#23684)
  ...
@BillyONeal
Copy link
Member

Hmmm I think this may have been correct before. <version> is something of a misnomer in that it's the minimum version we accept, not a metadata statement about what's at that download URI. Unless we really need to force a system that already had 3.10.1 to download 3.10.2?

@JonLiu1993 JonLiu1993 changed the title Fix <version> of Python in vcpkgTools.xml [python3] Fix <version> of Python in vcpkgTools.xml Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thomas1664 @BillyONeal @JonLiu1993 @dan-shaw