Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microsoft-signalr] Add missing header files #40873

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

jimwang118
Copy link
Contributor

One of the fixes for the #32398 issue.
The following error occurs when installing microsoft-signalr[core,messagepack]:x64-linux.

/mnt/vcpkg/buildtrees/microsoft-signalr/src/1.0-alpha4-e34fa42a98/src/signalrclient/binary_message_parser.h:13:62: error: ‘size_t’ has not been declared
/mnt/vcpkg/buildtrees/microsoft-signalr/src/1.0-alpha4-e34fa42a98/src/signalrclient/transport_factory.cpp:26:20: error: ‘runtime_error’ is not a member of ‘std’
Line 39:    26 |         throw std::runtime_error("not implemented");
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The feature test pass with following triplets:

x64-windows
x64-linux

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 9, 2024
@jimwang118 jimwang118 marked this pull request as ready for review September 10, 2024 01:42
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure these are submitted upstream?

@jimwang118
Copy link
Contributor Author

PR 99 was submitted upstream to fix it.

@BillyONeal BillyONeal merged commit 2077bde into microsoft:master Sep 10, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the fixes and submitting upstream!

@jimwang118 jimwang118 deleted the fix-microsoft-signalr branch September 11, 2024 02:04
@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants