Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on Azure Resources extension for Cloud Shell feature #958

Merged
merged 2 commits into from
May 10, 2024

Conversation

alexweininger
Copy link
Member

@alexweininger alexweininger commented May 7, 2024

Related to microsoft/vscode-azureresourcegroups#848

The idea is to make RGs an extension dependency so that users don't notice any UI changes. However, the entry point for cloud shell will now be contributed by RGs instead of Azure Account. This will be a great way to easily transition users to RGs.

Keeping the cloud shell code around because some extensions still rely on the API, which has yet to be migrated to RGs. One of which is https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azureterraform

They can rely on AA until we figure out a solution

@alexweininger alexweininger requested a review from a team as a code owner May 7, 2024 01:28
@nturinski
Copy link
Member

Offline: Told Alex that I think that it was fine to not remove all the unused code since that could potentially cause more headaches than just removing the entry point does.

@bwateratmsft
Copy link
Contributor

Worth trying out--what if someone installs this version of the Azure Account extension (that depends on Resources), plus an older version of the Azure Resources extension that depends on Azure Account. Circular dependency. Is there an easy escape?

@alexweininger
Copy link
Member Author

alexweininger commented May 9, 2024

Worth trying out--what if someone installs this version of the Azure Account extension (that depends on Resources), plus an older version of the Azure Resources extension that depends on Azure Account. Circular dependency. Is there an easy escape?

I tried this out and 1. it was really hard to do this, and 2. I could fix it by clicking update on the Resources extension.

@alexweininger alexweininger merged commit d3b08f9 into main May 10, 2024
3 checks passed
@alexweininger alexweininger deleted the alex/blush-rhinoceros branch May 10, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants