Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release pipeline #5231

Merged
merged 6 commits into from
Mar 23, 2021
Merged

Update release pipeline #5231

merged 6 commits into from
Mar 23, 2021

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Mar 22, 2021 •
edited
Loading

For #4961

  • Publish insiders daily at 2am PDT (9am UTC)
  • Publish release

@DonJayamanne DonJayamanne changed the title WIP DO NOT REVIEW - WIP Mar 22, 2021
@DonJayamanne DonJayamanne temporarily deployed to insider March 22, 2021 17:09 Inactive
@DonJayamanne DonJayamanne temporarily deployed to insider March 22, 2021 17:14 Inactive
@DonJayamanne DonJayamanne temporarily deployed to insider March 22, 2021 17:27 Inactive
@DonJayamanne DonJayamanne temporarily deployed to insider March 22, 2021 17:30 Inactive
@DonJayamanne DonJayamanne temporarily deployed to insider March 22, 2021 17:47 Inactive
@DonJayamanne DonJayamanne temporarily deployed to insider March 22, 2021 17:51 Inactive
@DonJayamanne DonJayamanne temporarily deployed to insider March 22, 2021 17:53 Inactive
@DonJayamanne DonJayamanne temporarily deployed to unknown March 22, 2021 18:53 Inactive
@DonJayamanne DonJayamanne temporarily deployed to unknown March 22, 2021 18:55 Inactive
@DonJayamanne DonJayamanne temporarily deployed to unknown March 22, 2021 18:56 Inactive
@DonJayamanne DonJayamanne temporarily deployed to unknown March 22, 2021 18:59 Inactive
@DonJayamanne DonJayamanne temporarily deployed to unknown March 22, 2021 19:01 Inactive
@DonJayamanne DonJayamanne temporarily deployed to insider March 22, 2021 19:04 Inactive
@DonJayamanne DonJayamanne changed the title DO NOT REVIEW - WIP Update release pipeline Mar 22, 2021
DonJayamanne
DonJayamanne commented Mar 22, 2021
View reviewed changes
.github/workflows/build-test.yml

- name: insiders channel
# Scheduled builds will publish Insider builds.
if: github.event_name == 'schedule' && github.ref == 'refs/heads/mains'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We push insiders to marketplace only during the nightly run

DonJayamanne
DonJayamanne commented Mar 22, 2021
View reviewed changes
.github/workflows/build-test.yml
run: |
echo "vsix_name=ms-toolsai-jupyter-release.vsix" >> $GITHUB_ENV
echo "test_matrix_os=[\"ubuntu-latest\"]" >> $GITHUB_ENV

- name: release channel
# All pushes to release can push to marketplace place with the words `release` `publish` in commit.
if: github.event_name == 'push' && contains(github.ref, 'refs/heads/release') && contains(github.event.head_commit.message, 'release') && contains(github.event.head_commit.message, 'publish')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We push insiders to marketplace only during push to release & commits has special comments

DonJayamanne
DonJayamanne commented Mar 22, 2021
View reviewed changes
.github/workflows/build-test.yml Outdated
name: ${{needs.pick_environment.outputs.vsix_name}}

# - name: Publish
# run: vsce publish --packagePath ${{needs.pick_environment.outputs.vsix_name}} --pat ${{secrets.VSCE_TOKEN}} --noVerify
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once reviewed, i'll enable this, only way to find out is to push a VSIX for insiders and test.

DonJayamanne
DonJayamanne commented Mar 22, 2021
View reviewed changes
.github/workflows/build-test.yml
name: ${{needs.pick_environment.outputs.vsix_name}}

- name: Publish
run: vsce publish --packagePath ${{needs.pick_environment.outputs.vsix_name}} --pat ${{secrets.VSCE_TOKEN}} --noVerify
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish insider/release

DonJayamanne
DonJayamanne commented Mar 22, 2021
View reviewed changes
.github/workflows/build-test.yml
run: vsce publish --packagePath ${{needs.pick_environment.outputs.vsix_name}} --pat ${{secrets.VSCE_TOKEN}} --noVerify

- name: Extract Extension
if: needs.pick_environment.outputs.release_channel == 'stable'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the rest only applies when we generate stable releases

DonJayamanne
DonJayamanne commented Mar 22, 2021
View reviewed changes
.github/workflows/build-test.yml Outdated
@@ -19,8 +19,9 @@ on:
- 'release'
- 'release/*'
- 'release-*'
schedule:
- cron: "0 9 * * *" 9am UTC (2am PDT)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nightly job

DonJayamanne
DonJayamanne commented Mar 22, 2021
View reviewed changes
.github/workflows/build-test.yml
if: github.repository == 'microsoft/vscode-jupyter' && (needs.pick_environment.outputs.release_channel == 'insider' || needs.pick_environment.outputs.release_channel == 'stable')
needs: [pick_environment, build-vsix, lint, ts_tests, smoke-tests]
environment:
name: ${{needs.pick_environment.outputs.release_channel}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Github Environments Releases
I have created two environments insider & stable.
For Insiders, they will get published directly.
For stable environment, this job will NOT run, until it is approved. there is a list of approvers that we can add (for now I had only added myself, to ensure this works properly, then we can add everyone else).

See here for more info:
https://docs.github.com/en/actions/reference/environments
https://docs.github.com/en/actions/managing-workflow-runs/reviewing-deployments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I will add @IanMatthewHuff as he's going to be doing the release this time

@DonJayamanne DonJayamanne marked this pull request as ready for review March 22, 2021 22:01
@DonJayamanne DonJayamanne requested a review from a team as a code owner March 22, 2021 22:01
@DonJayamanne DonJayamanne merged commit bce25ba into main Mar 23, 2021
@DonJayamanne DonJayamanne deleted the main2 branch March 23, 2021 00:17
@DonJayamanne DonJayamanne mentioned this pull request Mar 24, 2021
Closed
DonJayamanne added a commit to jakebailey/vscode-jupyter that referenced this pull request Mar 25, 2021
@DonJayamanne
Merge branch 'main' into pr/jakebailey/5169
c363113 
* main: (33 commits)
  Fix problems found while debugging synapse connections (microsoft#5297)
  Ask user to enable CDN support to render IPyWidget (microsoft#5282)
  Remove jupyter.useNotebookEditor (microsoft#5249)
  Fixes to creating and re-opning non-python notebooks (microsoft#5271)
  Update main part 2 (microsoft#5296)
  Fix problem with run selection in an editor (microsoft#5298)
  Avoid calling `reveal` if a webview is already active or visible (microsoft#5276)
  Remove default value from setting description (microsoft#5288)
  Use 'learn more' clickable link for setting (microsoft#5285)
  update to next version number (microsoft#5275)
  Fix display of non-numeric DataFrame index columns (microsoft#5254)
  Use resolveKernel instead of resolveDocument which is due for deprecation and re-enable and update associated tests. (microsoft#5255)
  Display survey only when dealing with Jupyter Notebooks (microsoft#5248)
  Remove java kernel tests from Notebooks (microsoft#5247)
  Fix scheduled build pipeline (microsoft#5245)
  Add string argument to jupyter.execSelectionInteractive for extensibility (microsoft#5053)
  Finally to make sure that we claen up our status message (microsoft#5239)
  Updates to Notebook kernel execution API (microsoft#5241)
  Changes to execution of Native Notebooks (changes in Proposed API) (microsoft#5180)
  Update release pipeline (microsoft#5231)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu DavidKutu approved these changes

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonJayamanne @rchiodo @DavidKutu