Add quick diff provider

Fixes #392
microsoft · Jan 18, 2023 · 5205860 · 5205860
1 parent 70dd0de
commit 5205860
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/@types/vscode.proposed.quickdiffProvider.d.ts b/src/@types/vscode.proposed.quickdiffProvider.d.ts
@@ -8,6 +8,6 @@ declare module 'vscode' {
 	// https://github.com/microsoft/vscode/issues/169012
 
 	export namespace window {
-		export function registerQuickDiffProvider(quickDiffProvider: QuickDiffProvider, label: string, rootUri?: Uri): Thenable<Disposable>;
+		export function registerQuickDiffProvider(selector: DocumentSelector, quickDiffProvider: QuickDiffProvider, label: string, rootUri?: Uri): Disposable;
 	}
 }
diff --git a/src/view/reviewManager.ts b/src/view/reviewManager.ts
@@ -172,14 +172,14 @@ export class ReviewManager {
 	}
 
 	private registerQuickDiff() {
-		vscode.window.registerQuickDiffProvider({
+		this._disposables.push(vscode.window.registerQuickDiffProvider({ scheme: 'file' }, {
 			provideOriginalResource: (uri: vscode.Uri) => {
 				const changeNode = this.reviewModel.localFileChanges.find(changeNode => changeNode.changeModel.filePath.toString() === uri.toString());
 				if (changeNode) {
 					return changeNode.changeModel.parentFilePath;
 				}
 			}
-		}, 'GitHub Pull Request', this.repository.rootUri);
+		}, 'GitHub Pull Request', this.repository.rootUri));
 	}
 
 	get statusBarItem() {