Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test mark as viewed #3332

Closed
2 tasks done
alexr00 opened this issue Feb 21, 2022 · 1 comment
Closed
2 tasks done

Test mark as viewed #3332

alexr00 opened this issue Feb 21, 2022 · 1 comment

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 21, 2022

Refs: #3287

Complexity: 3

Create Issue


The old UX for marking a file in a PR as viewed caused some button jumping and used icons that were hard to understand. Within the limitations of the tree view, we've tried to improve upon this.

  1. Install the pre-release version of GitHub Pull Requests and Issues (instructions: https://github.com/microsoft/vscode-pull-request-github/wiki/Pre-release-Build). Browser is fine if you want.
  2. Open a PR that you don't mind marking files as viewed in (You can open a PR from the "Pull Requests" view).
  3. Figure out how to mark a file as viewed. Verify that the icons representing "mark as viewed" and "mark as unviewed" make sense.
  4. Verify that when a file has been marked as viewed that it has no color and the git file decoration changes into a check.
  5. Verify that that when you mark a file as unviewed it regains it's color and file decoration.
@mjbvz
Copy link
Contributor

mjbvz commented Feb 23, 2022

Test on MacOS and seems to work well

To improve discoverability, could there also be a button in the editor tool bar that shows in diffs from a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants