Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Mark file as not viewed' triggered exception #3337

Closed
mjbvz opened this issue Feb 23, 2022 · 1 comment · Fixed by #3344
Closed

'Mark file as not viewed' triggered exception #3337

mjbvz opened this issue Feb 23, 2022 · 1 comment · Fixed by #3344
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
February 2022

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 23, 2022

Testing #3332

  1. Browse a pull request (don't actually check it out)
  2. Click on one of the files to view a diff
  3. In the command palette, run: mark file as not viewed

bug
I see an exception:

workbench.desktop.main.js:787 Marked file as not viewed failed: TypeError: Cannot read properties of undefined (reading 'pullRequest')
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Feb 24, 2022
@alexr00 alexr00 added this to the February 2022 milestone Feb 24, 2022
@alexr00
Copy link
Member

alexr00 commented Feb 24, 2022

That command should not be available from the command palette.

alexr00 added a commit that referenced this issue Feb 24, 2022
@alexr00
'Mark file as not viewed' triggered exception
75a88b4 
Fixes #3337
@alexr00 alexr00 mentioned this issue Feb 24, 2022
Merged
This was referenced Feb 25, 2022
Closed
Closed
@joyceerhl joyceerhl added the verified Verification succeeded label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

Successfully merging a pull request may close this issue.

'Mark file as not viewed' triggered exception microsoft/vscode-pull-request-github
3 participants
@mjbvz @joyceerhl @alexr00