Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render permalinked lines #4229

Closed
daviddossett opened this issue Nov 22, 2022 · 1 comment · Fixed by #4499
Closed

Render permalinked lines #4229

daviddossett opened this issue Nov 22, 2022 · 1 comment · Fixed by #4499
Assignees
@alexr00
Labels
feature-request Request for new features or functionality on-testplan
Milestone
February 2023

Comments

@daviddossett
Copy link
Contributor

It looks like we don't really render the lines and surrounding UI when linking directly to code. It would be great to better handle cases like this to make the delta from gh.com to the extension less jarring.

GHPRI

CleanShot 2022-11-22 at 09 58 31@2x

github.com

CleanShot 2022-11-22 at 09 58 40@2x
@lramos15 lramos15 assigned alexr00 and unassigned lramos15 Nov 22, 2022
@lramos15 lramos15 transferred this issue from microsoft/vscode Nov 22, 2022
@alexr00 alexr00 added the feature-request Request for new features or functionality label Nov 23, 2022
@alexr00 alexr00 added this to the December 2022 milestone Nov 23, 2022
@kieferrm kieferrm mentioned this issue Jan 2, 2023
Closed
@alexr00 alexr00 mentioned this issue Jan 23, 2023
Merged
alexr00 added a commit that referenced this issue Jan 23, 2023
@alexr00
Render permalinked lines in the comments widget
4aede76 
Part of  #4229
@alexr00 alexr00 modified the milestones: January 2023, February 2023 Jan 23, 2023
alexr00 added a commit that referenced this issue Jan 23, 2023
@alexr00
Render permalinked lines in the comments widget (#4429)
77988d2 
Part of  #4229
@kieferrm kieferrm mentioned this issue Feb 4, 2023
Closed
92 tasks
@alexr00
Copy link
Member

alexr00 commented Feb 6, 2023

No syntax highlighting (I'll see if it's feasible), but it's still a big improvement:

image

@alexr00 alexr00 mentioned this issue Feb 6, 2023
Merged
alexr00 added a commit that referenced this issue Feb 6, 2023
@alexr00
Render permalinked lines in overview/description
f50c315 
Fixes #4229
alexr00 added a commit that referenced this issue Feb 6, 2023
@alexr00
Render permalinked lines in overview/description (#4499)
a648ee9 
Fixes #4229
@alexr00 alexr00 mentioned this issue Feb 20, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

Render permalinked lines in overview/description microsoft/vscode-pull-request-github
3 participants
@lramos15 @daviddossett @alexr00