Skip to content

Commit

Permalink
Clean up smoke test requirement (#21729)
Browse files Browse the repository at this point in the history
Cleaning up smoke test dependency: See if all Github action test pass
with removing the smoke test requirement file content.

Checked one by one, and came to see removing all doesn't seem to have
impact on the outcome of running smoke test.(Seems to have no difference
in smoke test result outcome when ran with "Run and Debug" in VS Code
with smoke-test option selected).

Also got rid of below, after checking smoke test correctly passing after
removal of smoke-test-requirement.txt content:
![Screenshot 2023-08-01 at 2 57 45
PM](https://github.com/microsoft/vscode-python/assets/62267334/45d404de-74dd-45a5-885b-71a25ef16ad7)

Resolve: #21496
  • Loading branch information
anthonykim1 committed Aug 2, 2023
1 parent 358635d commit ef16727
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
6 changes: 0 additions & 6 deletions .github/actions/smoke-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ runs:
cache-dependency-path: |
build/test-requirements.txt
requirements.txt
build/smoke-test-requirements.txt
- name: Install dependencies (npm ci)
run: npm ci --prefer-offline
Expand All @@ -43,11 +42,6 @@ runs:
python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --implementation py --no-deps --upgrade --pre debugpy
shell: bash

- name: pip install smoke test requirements
run: |
python -m pip install --upgrade -r build/smoke-test-requirements.txt
shell: bash

# Bits from the VSIX are reused by smokeTest.ts to speed things up.
- name: Download VSIX
uses: actions/download-artifact@v2
Expand Down
6 changes: 0 additions & 6 deletions build/smoke-test-requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion scripts/onCreateCommand.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ source /workspaces/vscode-python/.venv/bin/activate
npx gulp installPythonLibs

/workspaces/vscode-python/.venv/bin/python -m pip install -r build/test-requirements.txt
/workspaces/vscode-python/.venv/bin/python -m pip install -r build/smoke-test-requirements.txt
/workspaces/vscode-python/.venv/bin/python -m pip install -r build/functional-test-requirements.txt

# Below will crash codespace
Expand Down

0 comments on commit ef16727

Please sign in to comment.