Skip to content

Commit

Permalink
pipe through the rest of the properties (#206636)
Browse files Browse the repository at this point in the history
  • Loading branch information
amunger committed Mar 1, 2024
1 parent 0e959d1 commit d759076
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/vs/workbench/api/common/extHost.protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1126,6 +1126,8 @@ export interface VariablesResult {
name: string;
value: string;
type?: string;
language?: string;
expression?: string;
hasNamedChildren: boolean;
indexedChildrenCount: number;
extensionId: string;
Expand Down
2 changes: 2 additions & 0 deletions src/vs/workbench/api/common/extHostNotebookKernels.ts
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,8 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
name: result.variable.name,
value: result.variable.value,
type: result.variable.type,
language: result.variable.language,
expression: result.variable.expression,
hasNamedChildren: result.hasNamedChildren,
indexedChildrenCount: result.indexedChildrenCount,
extensionId: obj.extensionId.value,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { ICellExecutionStateChangedEvent, IExecutionStateChangedEvent, INotebook
import { INotebookKernelService } from 'vs/workbench/contrib/notebook/common/notebookKernelService';
import { IEditorService } from 'vs/workbench/services/editor/common/editorService';

export type contextMenuArg = { source?: string; type?: string; value?: string; expression?: string; language?: string; extensionId?: string };
export type contextMenuArg = { source: string; name: string; type?: string; value?: string; expression?: string; language?: string; extensionId?: string };

export class NotebookVariablesView extends ViewPane {

Expand Down Expand Up @@ -109,6 +109,7 @@ export class NotebookVariablesView extends ViewPane {

const arg: contextMenuArg = {
source: element.notebook.uri.toString(),
name: element.name,
value: element.value,
type: element.type,
expression: element.expression,
Expand Down

0 comments on commit d759076

Please sign in to comment.