Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt bracket AST infrastructure for all bracket related features #132536

Closed
hediet opened this issue Sep 7, 2021 · 2 comments
Closed

Adopt bracket AST infrastructure for all bracket related features #132536

hediet opened this issue Sep 7, 2021 · 2 comments
Assignees
@hediet
Labels
debt Code quality issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2022

Comments

@hediet
Copy link
Member

hediet commented Sep 7, 2021

No description provided.

@hediet hediet added the feature-request Request for new features or functionality label Sep 7, 2021
@hediet hediet added this to the September 2021 milestone Sep 7, 2021
@hediet hediet self-assigned this Sep 7, 2021
@egamma egamma mentioned this issue Sep 7, 2021
Closed
99 tasks
@hediet hediet modified the milestones: September 2021, October 2021 Sep 30, 2021
@hediet hediet modified the milestones: October 2021, November 2021 Oct 28, 2021
@hediet hediet mentioned this issue Nov 2, 2021
Closed
12 tasks
@hediet hediet modified the milestones: November 2021, December 2021 Nov 30, 2021
@hediet hediet modified the milestones: January 2022, February 2022 Jan 24, 2022
@hediet hediet modified the milestones: February 2022, On Deck Feb 24, 2022
@kieferrm kieferrm mentioned this issue Mar 6, 2022
Closed
87 tasks
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@hediet hediet modified the milestones: On Deck, April 2022 Apr 11, 2022
hediet added a commit that referenced this issue Apr 11, 2022
@hediet
Adopts bracket pair AST for bracket pair matching when AST is availab…
e78ca55 
…le. Implements #132536.
@hediet
Copy link
Member Author

hediet commented Apr 13, 2022

Implemented in e78ca55.

@hediet hediet closed this as completed Apr 13, 2022
@hediet hediet added the debt Code quality issues label Apr 13, 2022
@joyceerhl joyceerhl added the verification-needed Verification of issue is requested label Apr 25, 2022
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@jrieken jrieken added the verification-steps-needed Steps to verify are needed for verification label Apr 27, 2022
@hediet
Copy link
Member Author

hediet commented Apr 27, 2022

verification steps:

  • Verify that bracket matching still works (when the cursor touches a bracket, the matching bracket is highlighted)
  • Test this for two arbitrary languages

@hediet hediet removed the verification-steps-needed Steps to verify are needed for verification label Apr 27, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
debt Code quality issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
4 participants
@jrieken @hediet @rzhao271 @joyceerhl