Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Terminal auto replies #141341

Closed
3 tasks done
Tyriar opened this issue Jan 24, 2022 · 4 comments
Closed
3 tasks done

Test: Terminal auto replies #141341

Tyriar opened this issue Jan 24, 2022 · 4 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 24, 2022

Refs: #133524

Complexity: 2

Authors: @Tyriar, @meganrogge

Create Issue


The terminal has a new feature called auto replies that will reply automatically when a particular sequence of characters is encountered in succession. The main use case for this feature is Windows batch scripts and their annoying Terminate batch job (Y/N)? question they ask, despite the backing process already being killed. The reply is throttled just in case something goes wrong.

The default for the setting is:

  "terminal.integrated.autoReplies": {
    "Terminate batch job (Y/N)": "Y\r"
  }

Do some exploratory testing, try to break it, etc. Whoever is on Windows make sure to test the primary use case of ctrl+c in a batch script, also make sure you can remove the default from the setting to disable it.

@Tyriar Tyriar added this to the January 2022 milestone Jan 24, 2022
@hello-smile6
Copy link
Contributor

@Tyriar Just wondering, will it be possible to disable that? It could potentially have issues. For example, sending "y" in response would potentially send non-HTTP data to an HTTP server if the user was downloading a file via telnet and that line was at the end of the response.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 25, 2022

@hello-smile6 you can delete the default item from the setting pretty easily to disable it completely. Maybe I'm misunderstanding but I don't think it would cause issues in the case you're talking about since Terminate batch job (Y/N) would have to happen first.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 25, 2022

@hello-smile6 this feature isn't meant to be a stop the user from deleting / protection, but a convenience thing to workaround a UX issue on Windows. It's just generalized so you can use it elsewhere if you want to.

@hello-smile6
Copy link
Contributor

@hello-smile6 this feature isn't meant to be a stop the user from deleting / protection, but a convenience thing to workaround a UX issue on Windows. It's just generalized so you can use it elsewhere if you want to.

Okay.

@sandy081 sandy081 assigned deepak1556 and unassigned aeschli Jan 25, 2022
@bamurtaugh bamurtaugh removed their assignment Jan 25, 2022
@deepak1556 deepak1556 removed their assignment Jan 25, 2022
@gregvanl gregvanl removed their assignment Jan 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants