Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old auto replies included in new terminal #141530

Closed
gregvanl opened this issue Jan 26, 2022 · 2 comments
Closed

Old auto replies included in new terminal #141530

gregvanl opened this issue Jan 26, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. verified Verification succeeded
Milestone

Comments

@gregvanl
Copy link

gregvanl commented Jan 26, 2022

Testing #141341

After creating a new terminal (type doesn't matter), a previous setting value still is included.

image

I had earlier had a setting value of:

    "terminal.integrated.autoReplies": {
        "Terminate batch job (Y/N)": "Y\r",
        "blah": "_blah_"
    }

The active terminal when the setting value was removed don't have the old value.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. labels Jan 26, 2022
@Tyriar Tyriar added this to the January 2022 milestone Jan 26, 2022
@Tyriar
Copy link
Member

Tyriar commented Jan 27, 2022

This seems to be working fine now after the null change was added.

@Tyriar Tyriar closed this as completed Jan 27, 2022
@kimadeline kimadeline added the verified Verification succeeded label Jan 28, 2022
@kimadeline
Copy link

Steps I took:

  • added the following to my settings.json:
    "terminal.integrated.autoReplies": {
        "blah": "_blah_"
    }
  • Opened a terminal and verified that typing blah resulted in blah_blah_
  • Changed the settings value to "blah": "what is it"
  • Opened a new terminal and verified that typing blah resulted in blahwhat is it

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants