Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting terminal moves prompt up #141403

Closed
bpasero opened this issue Jan 25, 2022 · 2 comments · Fixed by #141972
Closed

Splitting terminal moves prompt up #141403

bpasero opened this issue Jan 25, 2022 · 2 comments · Fixed by #141972
Assignees
@meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal-layout Issue relating to resizing, scroll bar position, terminal dimensions, etc.
Milestone
February 2022

Comments

@bpasero
Copy link
Member

bpasero commented Jan 25, 2022

Testing #141357
Recording 2022-01-25 at 12 39 09
@Tyriar Tyriar assigned meganrogge and unassigned sbatten Jan 25, 2022
@Tyriar Tyriar added the under-discussion Issue is under discussion for relevance, priority, approach label Jan 25, 2022
@Tyriar
Copy link
Member

Tyriar commented Jan 25, 2022

We'll need to repro on mac and look at the sequences to verify whether this is an issue or we're going the right thing.

@Tyriar Tyriar added confirmation-pending and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jan 25, 2022
@Tyriar Tyriar added this to the January 2022 milestone Jan 25, 2022
@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2022

I think this is working as designed since it's just padding on the top, however we could check the location of the terminal view and if it's on either side, top align the terminal instead of bottom aligning it.

@Tyriar Tyriar added polish Cleanup and polish issue terminal-layout Issue relating to resizing, scroll bar position, terminal dimensions, etc. and removed confirmation-pending labels Jan 26, 2022
@Tyriar Tyriar modified the milestones: January 2022, February 2022 Jan 26, 2022
meganrogge added a commit that referenced this issue Feb 1, 2022
@meganrogge
fix #141403
ac1bac6
@meganrogge meganrogge mentioned this issue Feb 1, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal-layout Issue relating to resizing, scroll bar position, terminal dimensions, etc.
Projects
None yet
Milestone
February 2022
Development

Successfully merging a pull request may close this issue.

set terminal alignment to top when panel is vertical microsoft/vscode
5 participants
@bpasero @Tyriar @sbatten @meganrogge and others