Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all built-in renders to be regular output renders #142429

Closed
rebornix opened this issue Feb 7, 2022 · 0 comments
Closed

Convert all built-in renders to be regular output renders #142429

rebornix opened this issue Feb 7, 2022 · 0 comments
Assignees
@rebornix
Labels
feature-request Request for new features or functionality notebook-find notebook-output on-release-notes Issue/pull request mentioned in release notes on-testplan
Milestone
March 2022

Comments

@rebornix
Copy link
Member

rebornix commented Feb 7, 2022 •
edited
Loading

Currently there are two types of renderers:

  1. Renderers contributed by extensions, they are loaded in the webview
  2. Renderers runs in the main frame, which takes care of some mimetypes supported out of the box: streaming text output, images, html, etc.

Moving the renderers all into extensions can simplify the code and also allows us to fully support Find in Outputs.
@rebornix rebornix mentioned this issue Feb 7, 2022
Closed
81 tasks
@rebornix rebornix changed the title 🔴 Convert all built-in renders to be regular output renders @rebornix Convert all built-in renders to be regular output renders Feb 7, 2022
@rebornix rebornix added feature-request Request for new features or functionality notebook-find notebook-output labels Feb 7, 2022
@rebornix rebornix added this to the February 2022 milestone Feb 7, 2022
rebornix added a commit that referenced this issue Feb 7, 2022
@rebornix
re #142429. Image renderer moved to extension.
f2b7964
rebornix added a commit that referenced this issue Feb 7, 2022
@rebornix
re #142429. html/svg renderer
ac308c3
rebornix added a commit that referenced this issue Feb 7, 2022
@rebornix
re #142429. javascript renderer
88e5c12
rebornix added a commit that referenced this issue Feb 8, 2022
@rebornix
re #142429. error output w/ dup ansi handling
c705227
@rebornix rebornix mentioned this issue Feb 9, 2022
Merged
@tvaucher tvaucher mentioned this issue Feb 16, 2022
Closed
@kieferrm kieferrm mentioned this issue Feb 16, 2022
Closed
15 tasks
@rebornix rebornix mentioned this issue Feb 19, 2022
Closed
2 tasks
@rebornix rebornix modified the milestones: February 2022, March 2022 Feb 23, 2022
@rebornix rebornix added the on-release-notes Issue/pull request mentioned in release notes label Mar 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
feature-request Request for new features or functionality notebook-find notebook-output on-release-notes Issue/pull request mentioned in release notes on-testplan
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
3 participants
@rebornix @greazer and others