Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keybindings] "panelPosition" 'when' condition no longer working #142749

Closed
jb2170 opened this issue Feb 10, 2022 · 3 comments
Closed

[Keybindings] "panelPosition" 'when' condition no longer working #142749

jb2170 opened this issue Feb 10, 2022 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) triage-needed

Comments

@jb2170
Copy link

jb2170 commented Feb 10, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.64.1
  • OS Version:

Steps to Reproduce:
The following used to allow me to swap my panel's position between bottom and right on-the-fly

    {
        "key": "shift+f4",
        "command": "workbench.action.positionPanelRight",
        "when": "panelPosition == 'bottom'"
    },
    {
        "key": "shift+f4",
        "command": "workbench.action.positionPanelBottom",
        "when": "panelPosition == 'right'"
    },

Now with the migration to workbench.action.movePanelToSidePanel and workbench.action.moveSidePanelToPanel the following does not work:

    {
        "key": "shift+f4",
        "command": "workbench.action.movePanelToSidePanel",
        "when": "panelPosition == 'bottom'"
    },
    {
        "key": "shift+f4",
        "command": "workbench.action.moveSidePanelToPanel",
        "when": "panelPosition == 'right'"
    },

It seems the panelPosition condition is not working.

@jb2170 jb2170 changed the title [Keybindings]' [Keybindings] "panelPosition" 'when' condition no longer working Feb 10, 2022
@meganrogge
Copy link
Contributor

works for me in insider's

This has already been fixed in Insider's and will be a part of our recovery release.

/duplicate #142176

@dankox
Copy link

dankox commented Feb 14, 2022

@meganrogge Does it work for you for both moves? I tried the insider and it works for moving the panel to the side panel, but not back. Basically the condition panelPosition == 'right' doesn't trigger the command.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) triage-needed
Projects
None yet
Development

No branches or pull requests

4 participants
@meganrogge @dankox @jb2170 and others