Keybind with when: panelPosition == right doesn't work

[dankox]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.64.2, 1.65.0-insider (Universal)
• OS Version: macOS Big Sur 11.6

Steps to Reproduce:

1. Setup keybindings like this:

    {
        "key": "shift+alt+j",
        "command": "workbench.action.moveSidePanelToPanel",
        "when": "panelPosition == 'right'"
    },
    {
        "key": "shift+alt+j",
        "command": "workbench.action.movePanelToSidePanel",
        "when": "panelPosition == 'bottom'"
    }

2. Open terminal panel and hit Shift + Option + J, it will move the panel to the side panel on the right side
3. Hit Shift + Option + J again and nothing happend. It should move it back to the bottom.
4. If the when condition is removed for moving it to the bottom and the other keybind is disabled, it works. So it seems like the panelPosition == 'right' is not recognized.

This worked on older versions of vscode. After the upgrade I had to update the commands (as explained in the release notes about new side panel), but I kept the when condition the same.

I know there were several issues with this which were fixed. And I also found this issue #142749 which reference the same problem but was closed as duplicate referencing other issue which doesn't seem like the same thing (the desrcription was about resizing, not moving and the commits associated with it also does not reference any panel position properties). It was mentioned also that the problem was not reproduced in the insider version. However, I can reproduce it in the insider obtained from the webpage.

[gjsjohnmurray]

/assign @sbatten

[ArturoDent]

Those commands:

View: Move Views From Side Panel To Panel
workbench.action.moveSidePanelToPanel

View: Move Views From Panel To Side Panel
workbench.action.movePanelToSidePanel

don't move the Panel. They move the views within the Panel to the Side Panel or vice versa. That is more clear when you look at the command descriptions rather than the command ids.

It does appear as if the Panel is moving because it closes automatically once all the views within it are moved elsewhere.

So the panelPosition context key never changes with the above commands. Your keybinding with "when": "panelPosition == 'right'" will never be triggered (assuming you have the Panel at the bottom to start with).

What are you trying to accomplish? If you want to move the Panel from the bottom to the side or vice versa use:

{
  "key": "shift+alt+j",
  "command": "workbench.action.positionPanelBottom",
  "when": "panelPosition == 'right'"
},

{
  "key": "shift+alt+j",
  "command": "workbench.action.positionPanelRight",
  "when": "panelPosition == 'bottom'"
}

[sbatten]

all the information from @ArturoDent is correct, but its a good callout of some UX ambiguity

[dankox]

@ArturoDent Thanks for explaining, it does make sense and I thought that probably I will need another condition to do this, but I couldn't figure out what that should be. Also vscode is reporting that I have duplicate keybind so I assumed that the condition probably stopped work (before it was ok).

What I'm trying to accomplish is to have one keybind to "move" the panel (terminal and all the other panels) to the side and back. Before I was able to do it with one keybind and the condition as shown in the description of the problem. I had it as a "toggle", swapping to side and bottom when necessary.
So I would like to know what kind of condition could I use to determine where the panel (or terminal view) is currently located. Is there such option now, or it's impossible after the panel change? Thanks for letting me know.

Sorry... totally misread the last comment. Thanks for the help with this.

[sbatten]

@ArturoDent has provided the recommended keybindings for the scenario that you want to move the panel instead of moving the views to the side panel. (Side panel name is leading to confusion and will likely be revisited soon).

[dankox]

@sbatten @ArturoDent I'm so sorry, I didn't really realized the shortcuts are different. Now I see. I just misread it sorry.
Yeah that works for me, so that's fine and this issue can be closed and thanks a bunch for the help.