Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use language status item to show formatter conflicts #148053

Closed
jrieken opened this issue Apr 25, 2022 · 2 comments
Closed

Use language status item to show formatter conflicts #148053

jrieken opened this issue Apr 25, 2022 · 2 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality formatting Source formatter issues on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2022

Comments

@jrieken
Copy link
Member

jrieken commented Apr 25, 2022

The can be multiple formatters installed per file, this often happens for JS/TS files after installing prettier. In such cases one formatter must be picked as default. Prompting for that is pretty aggressive when explicitly invoking format (modal dialog) but the conflict UI is very subtle when formatting automatically, e.g on save. In such flows we cannot show a modal and use a status bar message and silent notification instead. This isn't working so well (see #146544 and related) the issue is about using the language status item to show format conflicts
@jrieken jrieken self-assigned this Apr 25, 2022
@jrieken jrieken added feature-request Request for new features or functionality formatting Source formatter issues labels Apr 25, 2022
@jrieken jrieken modified the milestones: Backlog, April 2022 Apr 25, 2022
@jrieken jrieken mentioned this issue Apr 25, 2022
Closed
@jrieken
Copy link
Member Author

jrieken commented Apr 25, 2022

This is how it looks atm

Screenshot 2022-04-25 at 17 23 05

jrieken added a commit that referenced this issue Apr 25, 2022
@jrieken
add formatter conflict information (and ask to configure default) as …
5dad501 
…language status item, #148053
@jrieken jrieken closed this as completed Apr 25, 2022
@joyceerhl joyceerhl added the verification-needed Verification of issue is requested label Apr 25, 2022
This was referenced Apr 26, 2022
Closed
Closed
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 26, 2022
@rzhao271
Copy link
Contributor

I installed Prettier and switched to a JSON file and confirmed the error indicator shows up.
But, after selecting a default filter, the error indicator still shows.

@jrieken jrieken mentioned this issue Apr 27, 2022
Closed
jrieken added a commit to microsoft/vscode-docs that referenced this issue Apr 29, 2022
@jrieken
langauge status news, microsoft/vscode#145950, microsoft/vscode#148053
130db8d
@jrieken jrieken added the on-release-notes Issue/pull request mentioned in release notes label Apr 29, 2022
aeschli pushed a commit that referenced this issue May 2, 2022
@jrieken @aeschli
add formatter conflict information (and ask to configure default) as …
97dc95c 
…language status item, #148053
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality formatting Source formatter issues on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
3 participants
@jrieken @rzhao271 @joyceerhl