Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figuring out how to leave multi line comments. #148214

Closed
karthiknadig opened this issue Apr 26, 2022 · 1 comment · Fixed by #153310
Closed

Figuring out how to leave multi line comments. #148214

karthiknadig opened this issue Apr 26, 2022 · 1 comment · Fixed by #153310
Assignees
@alexr00
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2022

Comments

@karthiknadig
Copy link
Member

Testing #148048

I was trying to drag the + sign to select the lines I wanted to comment on.
image

I later realized that you had to select the text you wanted to comment on to get multi-line comments. Why not support both? If yo drag the + sign I would expect it to just select the whole line.
@IllusionMH
Copy link
Contributor

Had similar experience - tried to drag along gutter decoration - similar how it's done on GitHub - no luck.

Then tried to do multiline selection, open Command Palette and search for "Comment" - no luck GHPR extension only provides commands to collapse/expand comments.

This was a bit confusing for me because selection and click on + on GitHub - adds single line comment while drag of + required to do multiline.
Disclaimer: GH is only place where I've added multiline comments before this

@alexr00 alexr00 added feature-request Request for new features or functionality comments Comments Provider/Widget/Panel issues labels Apr 27, 2022
@alexr00 alexr00 added this to the May 2022 milestone Apr 27, 2022
@alexr00 alexr00 mentioned this issue May 11, 2022
Closed
@alexr00 alexr00 modified the milestones: May 2022, June 2022 May 31, 2022
@alexr00 alexr00 mentioned this issue Jun 27, 2022
Merged
alexr00 added a commit that referenced this issue Jun 27, 2022
@alexr00
Drag on + to leave multiline comment
cf29eba 
Fixes #148214
alexr00 added a commit that referenced this issue Jun 28, 2022
@alexr00
Drag on + to leave multiline comment (#153310)
5feeb83 
Fixes #148214
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 28, 2022
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Jun 28, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 29, 2022
@jrieken jrieken added the verified Verification succeeded label Jun 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Drag on + to leave multiline comment microsoft/vscode
6 participants
@IllusionMH @jrieken @karthiknadig @rzhao271 @alexr00 @VSCodeTriageBot