will crash after searching at extension panel

[HomyeeKing]

Does this issue occur when all extensions are disabled?: No

I search something at the extension detail page, then switch the tab, vscode got crash and exit

only can reproduce w/ the search operation(command + f), disable all the extension will be fine

Version: 1.76.1 (Universal)
Commit: 5e805b79fcb6ba4c2d23712967df89a089da575b
Date: 2023-03-08T16:32:09.831Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Darwin arm64 22.3.0
Sandboxed: No

Steps to Reproduce:

2023-03-14.14.19.35.mov

[mjbvz]

Please explain what that video is showing

[VSCodeTriageBot]

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

[HomyeeKing]

I search something at the extension detail page, then switch the tab, vscode got crash and exit

only can reproduce w/ the search operation(command + f), disable all the extension will be fine

[bpasero]

This looks possibly like a crash from the iframe search changes we did?

@HomyeeKing
Can you please follow the steps in https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues to get at more details around the crash and attach the result here? Thanks!

cc @deepak1556

[HomyeeKing]

no offend, doesn't the dump file contain some private information？
can you reproduce the issue at local and get the dmp yourself?

[bpasero]

It should not contain private information, for example it does not contain any memory, but @deepak1556 can confirm.

[HomyeeKing]

pending.zip

[rzhao271]

Looks like there's a regression in the iframe search code
symbolicated-58-2.log

[softopti]

Please explain what that video is showing

Do you still need additional information ?

[RamyRafik]

Any updates on this issue?
#191962 (Closed as a dupe of this) is giving me a really hard time, specially when it happens while a build/watcher is running.

[drasikhov]

Any updates? It's very annoying bug. Imagine you need to go through long documentation written in markdown:

1. You open it in the preview mode (either in a new tab or by side).
2. Try to search for something on preview page.
3. Switch to some other tab and then switch back to preview.
4. VSCode crashed.

[gjsjohnmurray]

@rzhao271 I just confirmed that the simple repro in #177046 (comment) still crashes today's Insiders. Perhaps once you're through the current endgame you can take a fresh look at this and try to get it fixed. In my experience it's very rare for VS Code to crash as comprehensively as it does with this repro.

[rzhao271]

Thanks for the ping. I just noticed that Sandeep closed some duplicates of this issue in the last few months, too.
Considering this bug most likely has to do with the patched version of Electron that VS Code uses, I'd like to see if I can get this assigned as a plan item for next iteration.

[EhabY]

Is there a workaround for custom webviews such that VS Code does not crash even when enabling the "Find Widget"?

I don't want to disable this feature since it is very useful for our webviews...

[Prateek-Wayne]

Today I also faced this issue
when I open preview for markdown file
and then do some search then vs code crashes

[rzhao271]

The current workaround is to close the find widget before switching away from the Markdown preview to prevent a crash.
I am reviewing some implementation details but have not had the time to create a patch in VS Code's Electron yet.