Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected focusing behavior of content hover inside of a Jupyter notebook #183529

Open
aiday-mar opened this issue May 26, 2023 · 3 comments
Open
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover
Milestone

Comments

@aiday-mar
Copy link
Contributor

This issue has first been noticed microsoft/vscode-jupyter#13263. While the core issue of 13263 has been solved, there remains an unexpected behavior of the focusing of the content hover inside of the Jupyter notebook.

  1. Open a Jupyter notebook
  2. Hover on code inside of a cell. Click on the hover, notice how the cell remains focused. 🐛
  3. Press Enter, the focus disappears from the hover and the cell? 🐛
  4. Press on the hover, the cell becomes focused, but the hover does not become visibly focused? 🐛
20230526_144350.mp4

cc @rebornix

@aiday-mar aiday-mar added bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover labels May 26, 2023
@aiday-mar aiday-mar self-assigned this May 26, 2023
@rebornix rebornix self-assigned this May 26, 2023
@rebornix rebornix added this to the May 2023 milestone May 26, 2023
@aiday-mar
Copy link
Contributor Author

Hi @rebornix, I will place this on the next milestone

@aiday-mar aiday-mar modified the milestones: May 2023, June 2023 May 30, 2023
rebornix added a commit that referenced this issue Jun 7, 2023
Re ##183529. Do not focus cell if hover is focused.
@rebornix rebornix closed this as completed Jun 7, 2023
@aiday-mar
Copy link
Contributor Author

Hi @rebornix, I am verifying the issue, I am wondering if it is expected that the following happens:

Screen.Recording.2023-06-28.at.15.29.43.mov

When I click on the hover, the hover focuses and the cell focuses too.

@rebornix
Copy link
Member

This is actually another case that I didn't cover.

@rebornix rebornix modified the milestones: June 2023, July 2023 Jun 28, 2023
@rebornix rebornix reopened this Jun 28, 2023
@rebornix rebornix modified the milestones: July 2023, August 2023 Jul 24, 2023
@aiday-mar aiday-mar modified the milestones: August 2023, Backlog Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover
Projects
None yet
Development

No branches or pull requests

2 participants