Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show skip file action for programs #19180

Closed
jrieken opened this issue Jan 24, 2017 · 8 comments
Closed

Don't show skip file action for programs #19180

jrieken opened this issue Jan 24, 2017 · 8 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jan 24, 2017

re #19096

  • Launch two debuggees
  • right click on one of the app nodes in the tree
  • 🐛 the menu shows the skip file entry

screen shot 2017-01-24 at 13 08 22

@roblourens
Copy link
Member

@isidorn I don't think I can control this?

"debug/callstack/context": [{
  "command": "extension.node-debug2.toggleSkippingFile",
  "group": "navigation"
}]

@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2017

@roblourens on my end I could only enable this context menu contributions on the stack frame elemnts but that feels a bit hackish. Extensions should be able to contribute some other actions to program / thread, so in a perfect world we would be able to specify somehow for what elements in the context menu should they be shown.
Having 3 different contribution points also feels a bit ugly, one for stack frame, one for thread, one for program

@jrieken suggestions are welcome

@roblourens
Copy link
Member

roblourens commented Jan 24, 2017

@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2017

@roblourens I think the when clause was designed with something else in mind, like when in debug. It does not feel natural to me to add a context when 'stackFrameSelected'

@roblourens
Copy link
Member

Most of them are like 'thingHasFocus' or 'thingIsVisible' but what we want seems analogous to "resourceLangId == markdown" which is how you can show context menu items only on certain types of files in the explorer. Like I'm imagining "callStackItemType = stackFrame".

That might be too specific though. Besides that, 3 different contribution points might be ok. Maybe @jrieken has a better idea.

@isidorn
Copy link
Contributor

isidorn commented Jan 25, 2017

@roblourens we can look into adding something like that in February

@roblourens roblourens added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Apr 19, 2017
@roblourens
Copy link
Member

Is this realistic or should we close it?

@isidorn
Copy link
Contributor

isidorn commented Nov 21, 2017

Sure we can do this but I do not see the end for this in the immediate future since nobody else complained.

isidorn added a commit to microsoft/vscode-node-debug that referenced this issue May 11, 2018
isidorn added a commit to microsoft/vscode-node-debug2 that referenced this issue May 11, 2018
@isidorn isidorn added the verification-needed Verification of issue is requested label May 11, 2018
@isidorn isidorn added this to the May 2018 milestone May 11, 2018
roblourens added a commit to microsoft/vscode-chrome-debug that referenced this issue May 12, 2018
@sandy081 sandy081 added the verified Verification succeeded label May 31, 2018
@isidorn isidorn added the release-notes Release notes issues label Jun 1, 2018
roblourens added a commit to microsoft/vscode-chrome-debug that referenced this issue Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants