Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config.test.ts - Tests Failing #44957

Closed
captainrdubb opened this issue Mar 2, 2018 · 2 comments
Closed

Config.test.ts - Tests Failing #44957

captainrdubb opened this issue Mar 2, 2018 · 2 comments
Assignees
@bpasero
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
March 2018

Comments

@captainrdubb
Copy link

Problem

The following tests are failing for me:
watching
watching also works when file created later

Digging Deeper

The config file name bubbling up from node fs_event_wrap to fs to vscode extfs to ConfigWatcher is incorrect.
filename

As a result, ConfigWatcher returns early in the onConfigFileChange event.
onfilechange

Is anyone else seeing this?
@captainrdubb captainrdubb mentioned this issue Mar 3, 2018
Closed
@bpasero bpasero assigned bpasero and unassigned isidorn Mar 4, 2018
@bpasero bpasero added info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed info-needed Issue requires more information from poster labels Mar 4, 2018
@bpasero bpasero added this to the March 2018 milestone Mar 6, 2018
@bpasero
Copy link
Member

bpasero commented Mar 7, 2018

@captainrdubb I pushed a fix via bafcdc6, maybe you could verify.

@bpasero bpasero closed this as completed Mar 7, 2018
bpasero added a commit that referenced this issue Mar 7, 2018
@bpasero
fix #44957
bafcdc6
@sandy081
Copy link
Member

@bpasero These tests were running green for me and also now. Shall I mark it as verified unless if there is a special way to verify. Also user has not come back after the fix.

@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2018
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

Successfully merging a pull request may close this issue.

Config Tests - Check Filename
5 participants
@bpasero @isidorn @captainrdubb @sandy081 @ramya-rao-a