Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging with smartStep disabled still shows frames labeled as "skipped by smartStep" #68464

Closed
roblourens opened this issue Feb 11, 2019 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded

Comments

@roblourens
Copy link
Member

Forked from #68127

  • Disable smartStep in a node launch config
  • Debug async/await code
  • See that non-sourcemapped frames are still grayed out and labeled as "skipped by smartStep"
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 11, 2019
@roblourens roblourens added this to the January 2019 Recovery milestone Feb 11, 2019
@roblourens roblourens self-assigned this Feb 11, 2019
roblourens added a commit that referenced this issue Feb 11, 2019
roblourens added a commit that referenced this issue Feb 11, 2019
@roblourens
Copy link
Member Author

Verification steps:

roblourens added a commit that referenced this issue Feb 12, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Feb 12, 2019
@cnshenj
Copy link

cnshenj commented Feb 13, 2019

@roblourens I see the changelog of 1.31.1 says #68464 is fixed. But this is what I'm seeing. The debugger is doing the exact opposite of desired behavior. It skips my code filter-box.tsx, while not skipping all library code (e.g. BaseButton.js, which is in node_modules).

Version: 1.31.1 (system setup)
Launch.json:

        {
            "type": "chrome",
            "request": "launch",
            "name": "Client",
            "url": "http://localhost:8080",
            "webRoot": "${workspaceFolder}",
            "sourceMaps": true,
            "sourceMapPathOverrides": {
                "webpack:///./*": "${webRoot}/*"
            },
            "smartStep": false
        }

grayed call stack

@roblourens
Copy link
Member Author

I haven't released this for the chrome extension yet, I'll do that now.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants