Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow settings UI TOC to be resized #79581

Closed
dalongi opened this issue Aug 21, 2019 · 6 comments · Fixed by #141195
Closed

Allow settings UI TOC to be resized #79581

dalongi opened this issue Aug 21, 2019 · 6 comments · Fixed by #141195
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues ux User experience issues
Milestone

Comments

@dalongi
Copy link
Contributor

dalongi commented Aug 21, 2019

The TOC in settings is rather narrow, and frequently truncates extension names. This feels especially unnecessary when using a wider display.
Screen Shot 2019-08-21 at 9 11 34 AM

This is not only triggered by extension names, but also affects built-in settings in non-English languages:
Screen Shot 2019-08-21 at 9 14 16 AM

Ideas:

  • Change the balance between the TOC and Settings Pane to give TOC more room
  • Increase the max-width and allow both TOC and Settings Pane to grow proportionally.
  • ...?
@gjsjohnmurray
Copy link
Contributor

@dalongi a probably-simple workaround might be to add the full name of the category as a hover tip for the truncated text.

@RMacfarlane RMacfarlane added the settings-editor VS Code settings editor issues label Aug 21, 2019
@roblourens
Copy link
Member

I don't really want to make things wider by default right now but a fancier UI would let you resize the TOC to your preference. I will add a tooltip now, should have had that already.

@roblourens roblourens added under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues labels Aug 22, 2019
@dalongi
Copy link
Contributor Author

dalongi commented Aug 23, 2019

@roblourens: Would additionally adding the resize UI be nontrivial? I'm not familiar with the UX framework being used, but could look into sending a PR if it's not too bad or there is an example to look at.

For changing the width: do you know how wide people typically have these panes? (Is it full window or partial due to having multiple editors?) When I have it open as the only window, I find it's easier to read the right-side setting descriptions when I shrink the window (~60-80 char per line instead of ~135 at max width)

@roblourens
Copy link
Member

roblourens commented Aug 23, 2019

Yeah I think it would be nontrivial. I would think that people usually use this full-window but I don't have a good sense of the average window width.

@roblourens roblourens added this to the Backlog milestone Oct 28, 2019
@SiddhanthUnnithan
Copy link

+1 to this. Our team has two extensions "Azure Machine Learning" and "Azure Machine Learning - Remote" that show up in the TOC as:

image

Users have to click through each of those options to get to the right extension. We purposely added "Remote" as a suffix so that both the main and remote extensions would be grouped together, as the list is sorted alphabetically today.

Would it be possible for users to expand the column width so they can see the full extension name?

@dandavison
Copy link

When using a wider window size, I think it would make sense to use the plentiful horizontal space rather than truncate:

image

@rzhao271 rzhao271 assigned rzhao271 and unassigned roblourens and rzhao271 Oct 15, 2021
@miguelsolorio miguelsolorio changed the title Settings UI TOC truncates category names, could make better use of horizontal space Allow settings UI TOC to be resized Oct 15, 2021
@miguelsolorio miguelsolorio removed their assignment Oct 15, 2021
@rzhao271 rzhao271 added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 29, 2021
@rzhao271 rzhao271 modified the milestones: Backlog, November 2021 Oct 29, 2021
@rzhao271 rzhao271 modified the milestones: November 2021, December 2021 Nov 23, 2021
@rzhao271 rzhao271 modified the milestones: January 2022, February 2022 Jan 24, 2022
rzhao271 added a commit that referenced this issue Feb 15, 2022
@rzhao271 rzhao271 added verification-needed Verification of issue is requested on-testplan and removed verification-needed Verification of issue is requested labels Feb 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues ux User experience issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants