Add support for parenthesis in "when" conditions

[Veetaha]

• VSCode Version: 1.42.0
• OS Version: Ubuntu 18.04.3

The when expression that contains parentheses which we set for a keybinding defined in the contribution point of our extension results into a corrupted (invalidly transformed expression in user's keybinding settings), e.g. the following declaration:

{
    "command": "extension.helloWorld",
    "key": "enter",
    "when": "editorLangId == rust && !suggestWidgetVisible && (!vim.active || vim.mode == 'Insert')"
}

produces the following invalid when expression:

Steps to Reproduce:

1. Go to the following repo with the reproduction
2. Follow the steps in README.md

Does this issue occur when all extensions are disabled?: Yes

[yasintz]

It should be able to properly handle something like
( (a&&(b|| c) && d) ) && !e && false && true || !(f != g) && (h == i).

[sandy081]

Keybindings editor is rendering the text generated by when context serialize method.

[alexdima]

Parenthesis are not supported

[vscodebot]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[alexdima]

The workaround is to use boolean algebra and express the same without paranthesis.

[vscodebot]

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[ulugbekna]

Hi, I have questions regarding this issue:

1. Would a fix for this issue be a parser that can handle parentheses (arbitrarily nested)?
2. If yes, would that parser be ideally handwritten or one could use a parser combinator library such as https://github.com/microsoft/ts-parsec?
3. How do we want to fail if the when clause is malformed, e.g., unmatched parentheses? My understanding is to log the error to console and return false as the evaluation of the clause.

[Spongman]

at the very least the Keyboard Shortcuts UI should reject inputs that contain parentheses (if they're not supported currently) instead of garbling the user input resulting in non-functioning expressions and no undo.

[starball5]

Related Stack Overflow question: Is there a NOT operator in VSCode Keybindings JSON to invert an entire "when" clause?

Please also remember to update the docs if/when this is implemented:

• https://code.visualstudio.com/api/references/when-clause-contexts#conditional-operators
• https://code.visualstudio.com/docs/getstarted/keybindings#_conditional-operators

[ulugbekna]

Hi everyone! 👋🙂

Support for parentheses in "when" clauses is now available in VS Code Insiders and is planned to be available in the March release of VS Code early next month.

We rewrote the parser to make it more flexible, correct, and easier to change. You can read more about upcoming changes: new features, breakages, migration help in this issue. You can subscribe to that issue to get more updates and/or leave us feedback there.

We also encourage you to test your extensions with VS Code Insiders to make sure things work as you expect, and use the new linter mentioned in the issue above to see if some of the when-clauses you have contain errors.