Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional directory syntax in file icon themes #140079

Merged
merged 13 commits into from Feb 3, 2022
Merged

Add optional directory syntax in file icon themes #140079

merged 13 commits into from Feb 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 4, 2022

This PR fixes #136656.

@ghost ghost mentioned this pull request Jan 4, 2022
Closed
Add extra segment for file-name priority
ff306e7 
Make `folder/*.ext` selector lower priority than `file.ext`.
@ghost
Copy link
Author

ghost commented Jan 4, 2022 •
edited by ghost
Loading

Couple issues raised in #137402:

  1. a common regex and match type was added after the transition to fileIconDirectoryRegex, but this was ideally meant to be extracted to a new vs/platform/theme/common/fileIcons.ts. Is this still something I should do?
  2. Icon selector priority of folder/*.ext should be below file.ext - an implementation is attempted in ff306e7 but not reviewed.

@aeschli
Copy link
Contributor

aeschli commented Jan 4, 2022

  1. No need to do that for now.

So I assume all is ready now to be reviewed? I'll have a look

@ghost
Copy link
Author

ghost commented Jan 4, 2022

Absolutely

@aeschli
Copy link
Contributor

aeschli commented Feb 3, 2022

I reviewed the changes and made some cosmetic changes.
Thanks @sndst00m !

@aeschli aeschli merged commit 318f04c into microsoft:main Feb 3, 2022
@aeschli aeschli modified the milestones: January 2022, February 2022 Feb 3, 2022
@aeschli aeschli added the themes Color theme issues label Feb 3, 2022
@ghost ghost deleted the feat-theme-dirname-class branch February 4, 2022 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
themes Color theme issues
Projects
None yet
Milestone
February 2022
Development

Successfully merging this pull request may close these issues.

[icon-themes] Support for folder / directory names in file associations (Icon themes)
1 participant
@aeschli