Separate quick diff API from SCM #170544
Merged
Separate quick diff API from SCM #170544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 1: split up the API. upcoming in part 2: In editor UX for multiple quick diffs. Fixes #169012
joaomoreno
requested changes
Jan 4, 2023
| } | ||
|
|
||
| export interface QuickDiff { | ||
| label: string; |
There was a problem hiding this comment.
What is this label for? How would it be any different from QuickDiffProvider.label?
There was a problem hiding this comment.
I expect to use it when showing UX to differentiate quick diffs from different providers. It's copied here from QuickDiffProvider so that callers of getQuickDiffs have access to the label.
joaomoreno
previously approved these changes
Jan 12, 2023
joaomoreno
approved these changes
Jan 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: split up the API.
upcoming in part 2: In editor UX for multiple quick diffs.
Part of #169012