Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show env var info in single tab #171500

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Show env var info in single tab #171500

merged 4 commits into from
Jan 17, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 17, 2023 •
edited
Loading

Fixes #171498

image

@Tyriar Tyriar added this to the January 2023 milestone Jan 17, 2023
@Tyriar Tyriar self-assigned this Jan 17, 2023
@Tyriar Tyriar marked this pull request as draft January 17, 2023 13:51
@Tyriar Tyriar mentioned this pull request Jan 17, 2023
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jan 17, 2023

@rzhao271 I'm changing the scroll bar logic in d39c5a4 to avoid cutting off the actions:

image

This may regress the scrolling, we can't set the height of the element though as we need it for successive layouts.

@Tyriar Tyriar marked this pull request as ready for review January 17, 2023 14:11
@Tyriar Tyriar merged commit b38b90d into main Jan 17, 2023
@Tyriar Tyriar deleted the tyriar/171498 branch January 17, 2023 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

Environment variable collection info not showing in single terminal tab
2 participants
@Tyriar @meganrogge