Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git gutter not shown in workspace with multiple folders (#176754) #176952

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Mar 13, 2023

Fixes #176738

When adding a folder to a workspace extension re-contribute their SCM. In this case, the old quick diff wasn't getting disposed.

This wasn't fixed by simply reloading becasue there was still a URI mismatch: the git extension gave the root URI with a lower case drive letter and the VS Code core often (depends on how the file was opened) give the file URI with an upper case drive letter.

* Git gutter not shown in workspace with multiple folders
Fixes #176738

* Use UriIdentityService
@alexr00 alexr00 self-assigned this Mar 13, 2023
@alexr00 alexr00 requested a review from joaomoreno March 13, 2023 10:58
@alexr00 alexr00 added the candidate Issue identified as probable candidate for fixing in the next release label Mar 13, 2023
@alexr00 alexr00 merged commit 8cb6281 into release/1.76 Mar 14, 2023
@alexr00 alexr00 deleted the alexr00/missingQuickDiff branch March 14, 2023 08:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants