EnvironmentVariableMutatorOptions API proposal #182883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
commented
May 18, 2023
|
When setting
PATH:
|
Tyriar
changed the title
sandy081
previously approved these changes
May 23, 2023
sandy081
previously approved these changes
May 23, 2023
sandy081
previously approved these changes
May 23, 2023
karrtikr
previously approved these changes
May 23, 2023
karrtikr
reviewed
May 23, 2023
Comment on lines
+14
to
+19
| /** | ||
| * Apply to the environment just before the process is created. | ||
| * | ||
| * Defaults to true. | ||
| */ | ||
| applyAtProcessCreation?: boolean; |
There was a problem hiding this comment.
It's not following: https://github.com/Microsoft/vscode/wiki/Extension-API-guidelines#undefined-is-false, are we okay with it in API sync?
There was a problem hiding this comment.
Let's bring this up at the API sync, undefined not being true would be harmful here imo.
karrtikr
approved these changes
May 23, 2023
karrtikr
approved these changes
May 23, 2023
karrtikr
reviewed
May 23, 2023
| this._setIfDiffers(variable, { value, type: EnvironmentVariableMutatorType.Replace, scope }); | ||
| replace(variable: string, value: string, options: vscode.EnvironmentVariableMutatorOptions | undefined, scope: vscode.EnvironmentVariableScope | undefined): void { | ||
| if (this._extension && options) { | ||
| isProposedApiEnabled(this._extension, 'envCollectionOptions'); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #179476