Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: improve performance when ending test with large number of results #186779

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

connor4312
Copy link
Member

Takes markTaskComplete 11,200ms to 70ms when running a 10k test suite,
by maintaining a count of computed states for children and avoiding
refreshing nodes unnecessarily.

For microsoft/vscode-python#21507

@connor4312 connor4312 enabled auto-merge (squash) June 30, 2023 19:17
@connor4312 connor4312 self-assigned this Jun 30, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the July 2023 milestone Jun 30, 2023
…sults

Takes `markTaskComplete` 11,200ms to 70ms when running a 10k test suite,
by maintaining a count of computed states for children and avoiding
refreshing nodes unnecessarily.

For microsoft/vscode-python#21507
@connor4312 connor4312 merged commit 01e8da3 into main Jun 30, 2023
5 checks passed
@connor4312 connor4312 deleted the connor4312/python-21507 branch June 30, 2023 21:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants