Add button to hide status bar of suggest widget #210896
Conversation
|
Idea was prompted by #142895. If I implement that (status bar on parameter hint widget) it'll make sense to default the new status bar as visible, in which case experienced users ought to be given a 1-click way of hiding it. |
|
I also experimented with adding a gearwheel button immediately left of the new close button, with the idea of making it open Settings Editor pre-populated with |
|
@daviddossett what do you think of this, UX wise? |
|
I like the idea, but shouldn't it be keyboard driven given that this is a suggest widget? I would have expected something like hide status bar (shortcut). More noise but more consistent with the other items. |
|
@daviddossett I think it's too noisy:
My intention is for the [X] to be a discreet indicator that this status bar can be hidden. Once hidden it could only be shown again by going to Settings Editor. I think it's unlikely that a user will change their mind frequently about whether or not they want it shown, in contrast to the "show more" / "show less" toggle that has a keyboard shortcut which the status bar "teaches" the new user about. |
|
Related - do you agree with me that "show more" should be "Show More", and the same capitalization should apply to "show less"? |
Agreed
As it stands, I agree. How does it feel with just "Hide" as the string? Have you thought about other less front-and-center approaches? For example, many toolbar buttons and tab-like elements in VS Code rely on right click to hide themselves. While not the most discoverable, it's at least consistent.
|
|
I worry it wouldn't be obvious that a "Hide" label was an action on the status bar of the suggest widget when the other actions apply to the widget. I haven't experimented with a context menu on the status bar, with a Hide Status Bar option. As you say it isn't so discoverable. There's already precedent for an X button at the right-hand end of a widget closing that widget. |
|
@daviddossett any further thoughts about this? |
Done in #225431 |
This aims to help new users get the best from the suggest widget by defaulting its status bar to be visible, and also adding a button to easily change the setting to false.