Fix shell integration for append/prepend EnvironmentVariableCollection API #223450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n API Add missing `:` separator in the variable setter for append and prepend for bash/zsh and fish. Withtout it last entry of first list and first entry of second list will merge into one string. Add quotes around all the expression that eval into strings in fish integration, for safety sake.
|
I was overly focused on fixing the issue for PATH, while not realizing that this code is generic. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
:separator in the variable setter for append and prepend for bash/zsh and fish. Withtout it last entry of first list and first entry of second list will merge into one string.Add quotes around all the expression that eval into strings in fish integration, for safety sake.