Implement rectangle renderer and gpu rulers view part #228632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
commented
Sep 17, 2024
| } | ||
|
|
||
| register(x: number, y: number, width: number, height: number, red: number, green: number, blue: number, alpha: number): IObjectCollectionBufferEntry<RectangleRendererEntrySpec> { | ||
| // TODO: Expand buffer if needed |
Tyriar
commented
Sep 17, 2024
| // --- end event handlers | ||
|
|
||
| private _update() { | ||
| // TODO: Only write dirty range |
Tyriar
changed the title
alexr00
approved these changes
Sep 17, 2024
Tyriar
commented
Sep 17, 2024
Comment on lines
+218
to
+220
| const rulers = this._viewGpuContext | ||
| ? new RulersGpu(this._context, this._viewGpuContext) | ||
| : new Rulers(this._context); |
There was a problem hiding this comment.
@hediet FYI this is how the other ruler's implementation is being added, similar to ViewLinesGpu but the DOM one isn't being instantiated at all.
Comment on lines
+52
to
+54
| const options = this._context.configuration.options; | ||
| const rulers = options.get(EditorOption.rulers); | ||
| const typicalHalfwidthCharacterWidth = options.get(EditorOption.fontInfo).typicalHalfwidthCharacterWidth; |
There was a problem hiding this comment.
At least for rulers, there isn't much opportunity to share code with the DOM implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221211
Also respects scroll left for character rendering.