IDE0060: Remove unused parameter (#3854)

.editorconfig

@@ -112,7 +112,9 @@ dotnet_diagnostic.IDE0032.severity = warning        # not default, set in accord
 dotnet_style_readonly_field = true:warning
 
 # Parameter preferences
-dotnet_code_quality_unused_parameters = all:suggestion
+dotnet_code_quality_unused_parameters = all:warning
+# IDE0060: Remove unused parameter
+dotnet_diagnostic.IDE0060.severity = warning
 
 # Suppression preferences
 dotnet_remove_unnecessary_suppression_exclusions = none

playground/TestPlatform.Playground/Program.cs

@@ -20,7 +20,7 @@ namespace TestPlatform.Playground;
 
 internal class Program
 {
-    static void Main(string[] args)
+    static void Main()
     {
         // This project references TranslationLayer, vstest.console, TestHostProvider, testhost and MSTest1 projects, to make sure
         // we build all the dependencies of that are used to run tests via VSTestConsoleWrapper. It then copies the components from

src/Microsoft.TestPlatform.CommunicationUtilities/TestRequestSender.cs

@@ -771,7 +771,9 @@ private static ICommunicationEndPoint SetCommunicationEndPoint(TestHostConnectio
 
 internal class MessageConverter
 {
+#pragma warning disable IDE0060 // Remove unused parameter // TODO: Use or remove this parameter and the associated method
     internal static AttachDebuggerInfo ConvertToAttachDebuggerInfo(TestProcessAttachDebuggerPayload attachDebuggerPayload, Message message, int protocolVersion)
+#pragma warning restore IDE0060 // Remove unused parameter
     {
         // There is nothing to do differently based on those versions.
         //var sourceVersion = GetVersion(message);
@@ -784,8 +786,8 @@ internal static AttachDebuggerInfo ConvertToAttachDebuggerInfo(TestProcessAttach
         };
     }
 
-    private static int GetVersion(Message message)
-    {
-        return (message as VersionedMessage)?.Version ?? 0;
-    }
+    //private static int GetVersion(Message message)
+    //{
+    //    return (message as VersionedMessage)?.Version ?? 0;
+    //}
 }

src/Microsoft.TestPlatform.CrossPlatEngine/Execution/BaseRunTests.cs

@@ -5,6 +5,7 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.IO;
 using System.Linq;
@@ -116,6 +117,7 @@ protected BaseRunTests(
     /// <param name="testEventsPublisher">Publisher for test events.</param>
     /// <param name="platformThread">Platform Thread.</param>
     /// <param name="dataSerializer">Data Serializer for cloning TestCase and test results object.</param>
+    [SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "Part of the public API")]
     protected BaseRunTests(
         IRequestData requestData,
         string? package,

src/Microsoft.TestPlatform.ObjectModel/TestProperty/TestProperty.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Reflection;
 using System.Runtime.Serialization;
@@ -384,6 +385,7 @@ public static bool TryUnregister(string id, out KeyValuePair<TestProperty, HashS
         return false;
     }
 
+    [SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "Part of the public API")]
     public object GetRealObject(StreamingContext context)
     {
         var registeredProperty = Find(Id);

src/Microsoft.TestPlatform.PlatformAbstractions/VersionAttribute.cs

@@ -11,7 +11,9 @@ internal class VersionAttribute : Attribute
 {
     public string? Description { get; set; }
 
+#pragma warning disable IDE0060 // Remove unused parameter // TODO: Do something with version or remove it
     public VersionAttribute(int version)
+#pragma warning restore IDE0060 // Remove unused parameter
     {
 
     }

src/Microsoft.TestPlatform.Utilities/InferRunSettingsHelper.cs

@@ -643,6 +643,7 @@ public static bool TryGetFrameworkXml(XPathNavigator runSettingsNavigator, out s
     /// Returns the sources matching the specified platform and framework settings.
     /// For incompatible sources, warning is added to incompatibleSettingWarning.
     /// </summary>
+    [SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "Part of the public API")]
     public static IEnumerable<string> FilterCompatibleSources(Architecture chosenPlatform, Architecture defaultArchitecture, Framework chosenFramework, IDictionary<string, Architecture> sourcePlatforms, IDictionary<string, Framework> sourceFrameworks, out string incompatibleSettingWarning)
     {
         incompatibleSettingWarning = string.Empty;

src/vstest.console/Processors/ListFullyQualifiedTestsArgumentProcessor.cs

@@ -134,7 +134,7 @@ internal ListFullyQualifiedTestsArgumentExecutor(
         _testRequestManager = testRequestManager;
 
         _runSettingsManager = runSettingsProvider;
-        _discoveryEventsRegistrar = new DiscoveryEventsRegistrar(output, _discoveredTests, _commandLineOptions);
+        _discoveryEventsRegistrar = new DiscoveryEventsRegistrar(_discoveredTests, _commandLineOptions);
     }
 
     #region IArgumentExecutor
@@ -193,7 +193,7 @@ private class DiscoveryEventsRegistrar : ITestDiscoveryEventsRegistrar
         private readonly List<string> _discoveredTests;
         private readonly CommandLineOptions _options;
 
-        public DiscoveryEventsRegistrar(IOutput output, List<string> discoveredTests, CommandLineOptions cmdOptions)
+        public DiscoveryEventsRegistrar(List<string> discoveredTests, CommandLineOptions cmdOptions)
         {
             _discoveredTests = discoveredTests;
             _options = cmdOptions;