-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf improvements #1517
Perf improvements #1517
Changes from all commits
10b4b59
3be52de
abfc9ca
eca43d7
aae3a17
4d1fb14
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,15 +28,17 @@ public interface ITestPlatform : IDisposable | |
/// </summary> | ||
/// <param name="requestData">Providing common services and data for Discovery</param> | ||
/// <param name="discoveryCriteria">Specifies the discovery parameters</param> | ||
/// <param name="options">Test platform options.</param> | ||
/// <returns>DiscoveryRequest object</returns> | ||
IDiscoveryRequest CreateDiscoveryRequest(IRequestData requestData, DiscoveryCriteria discoveryCriteria); | ||
IDiscoveryRequest CreateDiscoveryRequest(IRequestData requestData, DiscoveryCriteria discoveryCriteria, TestPlatformOptions options); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
this is a public interface. isnt this a breakingchange There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no this is not, since Tpv2 this Interface is not meant to be implemented by anyone outside vstest.console |
||
|
||
/// <summary> | ||
/// Creates a test run request. | ||
/// </summary> | ||
/// <param name="requestData">Providing common services and data for Execution</param> | ||
/// <param name="testRunCriteria">Specifies the test run criteria</param> | ||
/// <param name="options">Test platform options.</param> | ||
/// <returns>RunRequest object</returns> | ||
ITestRunRequest CreateTestRunRequest(IRequestData requestData, TestRunCriteria testRunCriteria); | ||
ITestRunRequest CreateTestRunRequest(IRequestData requestData, TestRunCriteria testRunCriteria, TestPlatformOptions options); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming adapters to customer havent taken a dependency on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://mseng.visualstudio.com/_search?type=code&lp=custom-Collection&text=ITestPlatform&_a=contents&result=DefaultCollection%2FVSOnline%2FVSO%2FGBmaster%2F%2FTfs%2FExtendedClient%2FTestPlatform%2FClient%2FUtilities.cs&filters=ProjectFilters%7BVSOnline%7D
In reply to: 177697101 [](ancestors = 177697101)