Understanding category attribute from adapter #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Apr 5, 2018
| { | ||
| public enum AssemblyType | ||
| { | ||
| NativeAndManaged, |
There was a problem hiding this comment.
consider None or Unspecified ?
singhsarab
reviewed
Apr 5, 2018
| @@ -124,5 +125,13 @@ public void TestDiscovererMetadataCtorSetsDefaultUri() | |||
|
|
|||
| Assert.AreEqual("executor://helloworld/", metadata.DefaultExecutorUri.AbsoluteUri); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
There was a problem hiding this comment.
Add a test for default case
There was a problem hiding this comment.
enum can't be null ro empty. Thus checking one test that whatever is passed is set enough.
| { | ||
| public enum AssemblyType | ||
| { | ||
| NativeAndManaged, |
There was a problem hiding this comment.
do we need NativeAndManaged, can't we ask user specify Category attribute two time?
There was a problem hiding this comment.
Category attribute is not supported multiple times.
Adapter which supports both native and managed will not specify category attribute.
|
@dotnet-bot test this please |
|
@dotnet-bot test this |
|
@dotnet-bot test this please |
1 similar comment
|
@dotnet-bot test this please |
|
@dotnet-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of RFC:
Contains changes for understanding category attribute from adapter.