-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vstest to honor nologo input from dotnet.exe #1717
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,7 +93,16 @@ internal int Execute(params string[] args) | |
{ | ||
this.testPlatformEventSource.VsTestConsoleStart(); | ||
|
||
this.PrintSplashScreen(); | ||
// If User specifies --nologo via dotnet, donot print splat screen | ||
if (args != null && args.Length !=0 && args.Contains("--nologo")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move this logic to function. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Case insensitive? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we are controlling this argument, can make case insensitive, but didn't need it now There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we support There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we are not supporting this as first class argument yet, only if it comes from dotnet cli, & from dotnet cli it will always come as --nologo. I don't want to add additional checks for something we are not supporting |
||
{ | ||
// Sanitizing this list, as I don't think we should write Argument processor for this. | ||
args = args.Where(val => val != "--nologo").ToArray(); | ||
} | ||
else | ||
{ | ||
this.PrintSplashScreen(); | ||
} | ||
|
||
int exitCode = 0; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create corresponding PR in dotnet cli repo.