Suggest publish for running on an isolated machine #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user in case test host file is not found.
abhishkk
approved these changes
Aug 10, 2018
| } | ||
|
|
||
| /// <summary> | ||
| /// Looks up a localized string similar to Unable to find test host at {0}. Please publish your test project and retry. |
There was a problem hiding this comment.
Nit: comment should match with resource string
| public void GetTestHostProcessStartIfDepsFileAndTestHostNotFoundShouldThrowException() | ||
| { | ||
| this.mockFileHelper.Setup(fh => fh.Exists("test.deps.json")).Returns(false); | ||
| this.mockFileHelper.Setup(ph => ph.Exists("testhost.dll")).Returns(false); |
There was a problem hiding this comment.
UT for testhost dll true and deps false case.
| // Try resolving testhost from output directory of test project. This is required if user has published the test project | ||
| // and is running tests in an isolated machine. A second scenario is self test: test platform unit tests take a project | ||
| // dependency on testhost (instead of nuget dependency), this drops testhost to output path. | ||
| testHostPath = Path.Combine(sourceDirectory, "testhost.dll"); | ||
| EqtTrace.Verbose("DotnetTestHostManager: Assume published test project, with test host path = {0}.", testHostPath); | ||
|
|
||
| if (!this.fileHelper.Exists(testHostPath)) |
There was a problem hiding this comment.
seems like we could simply replace the message above at line 216 with this new resource?
There was a problem hiding this comment.
We are caching the error above, and then throwing that.
singhsarab
added a commit
that referenced
this pull request
Aug 13, 2018
This reverts commit c7472a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For test projects targetting net core, give actionable message to the user in case test host file is not found.
Related issue
#1585