Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning the remaining set of dependencies for source build. #2058

Merged
merged 7 commits into from
Jun 21, 2019

Conversation

singhsarab
Copy link
Contributor

a. Microsoft.Build.Framework and Microsoft.Build.Utilities.Core to source built version: 16.0.461
b. Microsoft.Extensions.DependencyModel to source built version: 3.0.0-preview4-27615-11
c. Removed the redundant reference to Microsoft.Internal.Dia.Interop
d. Adding check for source build for StyleCop.Analyzers

Related issue

dotnet/source-build#896

a. Microsoft.Build.Framework and Microsoft.Build.Utilities.Core to source built version: 16.0.461
b. Microsoft.Extensions.DependencyModel to source built version: 3.0.0-preview4-27615-11
c. Removed the redundant reference to Microsoft.Internal.Dia.Interop
d. Adding check for source build for StyleCop.Analyzers

<!-- Add localized resources -->
<file src="Microsoft.TestPlatform.Build\netstandard1.3\**\*.dll" target="lib\netstandard1.3" />
<file src="Microsoft.TestPlatform.Build\netstandard2.0\**\*.dll" target="lib\netstandard2.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check how is Tp.build package is inserted in CLI, if they are unzipping, & then copying from ns1.3 folder explicitly, this would fail now

@@ -17,7 +17,7 @@
<group targetFramework="netcoreapp1.0">
<dependency id="Microsoft.TestPlatform.ObjectModel" version="$Version$"/>
<dependency id="Newtonsoft.Json" version="$JsonNetVersion$"/>
<dependency id="Microsoft.Extensions.DependencyModel" version="1.0.3"/>
<dependency id="Microsoft.Extensions.DependencyModel" version="3.0.0-preview4-27615-11"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this parameterized as we do for JsonNetVersion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed from Test Host nuspec.

@singhsarab singhsarab merged commit fb3545c into microsoft:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants