Fix running self-contained apps on Windows #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… run (on Windows)
|
Your running into the same problem i was |
cvpoienaru
reviewed
Mar 9, 2020
cvpoienaru
reviewed
Mar 9, 2020
test/Microsoft.TestPlatform.AcceptanceTests/Extension/NetCoreTargetFrameworkDataSource.cs
Show resolved
Hide resolved
cvpoienaru
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always copy testhost.exe to the output directory to allow applications that are self contained to run. When application defines both RuntimeIdentifier and OutputType = Exe it will be packaged as self-contained and the test host from .nuget will not be able to resolve the hostfxr dll, because dotnet will try to find it next to the application. See dotnet/runtime#3569 (comment) and below for more information on the behavior.